Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out fopro? #8153

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Try out fopro? #8153

wants to merge 13 commits into from

Conversation

fasterthanlime
Copy link
Contributor

Summary

This tries out https://github.com/bearcove/fopro when running cargo tests on linux

@zanieb
Copy link
Member

zanieb commented Oct 13, 2024

fyi I reran the latest ubuntu test job to see what happened when there was a cache hit — looks like about a minute faster! It failed though haha :)

@fasterthanlime
Copy link
Contributor Author

looks like about a minute faster

Unfortunately, it's not! I opened #8160 to do a fair comparison and at least on Linux with the current setup, it's not making a different in CI. (I see a difference locally but... I'd like more than that!)

@zanieb
Copy link
Member

zanieb commented Oct 13, 2024

Interesting. A few things come to mind:

  1. Linux is already the fastest, are there benefits on other platforms?
  2. Is there more benefit if we reduce the runner size? We increased the runner size several times to get a quick speed improvement, but that compute isn't free!
  3. Is it faster for most tests but some slow tests that aren't network bound are the bottleneck?

@fasterthanlime
Copy link
Contributor Author

fasterthanlime commented Oct 13, 2024

3. Is it faster for most tests but some slow tests that aren't network bound are the bottleneck?

Probably! Selecting lock:: tests and forcing -j1 shows that, y'know, fopro is not doing nothing:

with fopro it runs in 77s, without it run in 89s

...and there's still some things it doesn't cache, like git clones, HEAD requests, byte range requests, etc. — which aren't that hard to add, tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants