Fix CI issues related to the GitHub action upload-artifact
#2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- https://github.com/astronomer/astro-sdk/actions/runs/10957200761/job/30424844404\?pr\=2187 - issue that would come after, similar to what we experienced in the Ray Provider and Cosmos projects
…h without GH actions cancelling each other, as seen in https://github.com/astronomer/astro-sdk/actions/runs/10957453565/job/30425642217\?pr\=2188
tatiana
commented
Sep 20, 2024
| @@ -1,16 +1,10 @@ | |||
| name: Build and test astro Python SDK | |||
| on: | |||
| push: | |||
| branches: [ 'main', 'release-**' ] | |||
| branches: [ 'main', 'release-**', 'fix-ci' ] | |||
There was a problem hiding this comment.
Suggested change
| branches: [ 'main', 'release-**', 'fix-ci' ] | |
| branches: [ 'main', 'release-**' ] |
Comment on lines
6
to
7
| - 'python-sdk/**' | ||
| - '.github/workflows/ci-python-sdk.yaml' |
There was a problem hiding this comment.
Suggested change
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| pull_request: | |
| branches: [ 'main', 'release-**' ] | |
| paths: | |
| - 'python-sdk/**' | |
| - '.github/workflows/ci-python-sdk.yaml' | |
| - '*' |
pankajkoti
approved these changes
Sep 20, 2024
tatiana
commented
Sep 20, 2024
| @@ -601,6 +602,7 @@ jobs: | |||
| name: constraints-${{ matrix.python }}-${{ matrix.airflow }} | |||
| path: ./python-sdk/constraints-${{ matrix.python }}-${{ matrix.airflow }} | |||
| if-no-files-found: error | |||
| include-hidden-files: true | |||
|
|
|||
| Code-Coverage: | |||
| if: github.event.action != 'labeled' | |||
There was a problem hiding this comment.
I just noticed some tests failed due to uploading artefacts with the same name; this has to be addressed before we merge this PR. This project thas not been actively maintained for a while, so we may uncover other issues before this PR can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI issues, as experienced in https://github.com/astronomer/astro-sdk/actions/runs/10957200761/job/30424844404\?pr\=2187
This PR also fixes the issue that would come after, similar to what we experienced in the Ray Provider and Cosmos projects.