-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate DataStore
with MultiPack
#834
Conversation
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 80.54% 80.63% +0.08%
==========================================
Files 252 253 +1
Lines 19363 19295 -68
==========================================
- Hits 15596 15558 -38
+ Misses 3767 3737 -30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is quite a bit changes in the code, but we probably need to add test cases specifically designed for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remember to add the parameter documentation to the functions
- Some of the complex cases are not tested, like here: https://app.codecov.io/gh/asyml/forte/compare/834/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr%20comments&utm_term=asyml#D7L151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- there is a big decrease in coverage on
core.py
for 43 lines: https://app.codecov.io/gh/asyml/forte/compare/834/changes. What happens? - Ci failed after merging to master
|
If the test cases are no longer needed (using pointers), we can delete those branches. |
This PR fixes #833.
Description of changes
_pending_entries
delete_entry
on_entry_creation
to support new approach for entry creationdata_store.py
SortedList
containers and store the entries toDataStore
_add_entry_with_check
,get
,delete_entry
accordinglyBasePack
EntryConverter
:entry_converter.py
add_multipack_entries_raw()
allow_duplicate
option when adding some some non-annotation entriesMultiEntry
s and store their attributes toDataStore
. Any calls that may update these entries' attributes will be directed toDataStore
.Possible influences of this PR.
The integration is not fully tested and it might be unstable.
Test Conducted
The integration should successfully pass all the current CI tests. Will need more dedicated test cases in future #808.