-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json method for pack serialization/deserialization #917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
+ Coverage 80.99% 81.06% +0.06%
==========================================
Files 256 256
Lines 19821 19851 +30
==========================================
+ Hits 16055 16093 +38
+ Misses 3766 3758 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something serialization example (the actual json file) in the example folder: https://github.com/asyml/forte/tree/master/examples/serialization
This PR is the first step towards fixing #836.
Description of changes
Serialize/deserialize pack into/from json data.
Possible influences of this PR.
Remove dependency on pickle and jsonpickle in pack deserilization/serialization.
Test Conducted
entry_data_structures_test.py
multi_pack_test.py
entry_data_structures_test.py