Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io write by_ref #525

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Nov 13, 2019

#131
Maybe it's a break change, because WriteExt and ReadExt both have by_ref.

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Nov 14, 2019

I tried doing this as part of #314 a while ago. I think the right way to go about this is to add the methods to the futures-rs implementations so they can be directly targeted.

I think this could indeed be considered a breaking change if we merged it here directly. My guess is we wouldn't break too much, but there's no harm in leaning a bit more on the conservative side here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants