Fix panic when Delay is used after Poll::Ready
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblique
force-pushed
the
fix/wasm-panic
branch
2 times, most recently
from
977239e
to
e2163ce
Compare
oblique
changed the title
Delay is reused before resetting
oblique
changed the title
Delay is reused before resettingDelay is used after Poll::Ready
Merged
4 tasks
oblique
added a commit
to oblique/rust-libp2p
that referenced
this pull request
Jun 6, 2024
This PR workarounds async-rs/futures-timer#74 issue. Fixes libp2p#5442
mergify bot
pushed a commit
to libp2p/rust-libp2p
that referenced
this pull request
Jun 10, 2024
This PR workarounds async-rs/futures-timer#74 issue. Fixes #5442 Pull-Request: #5447.
TimTinkers
pushed a commit
to unattended-backpack/rust-libp2p
that referenced
this pull request
Sep 14, 2024
This PR workarounds async-rs/futures-timer#74 issue. Fixes libp2p#5442 Pull-Request: libp2p#5447.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM implementation was inconsistent to the native once when
Delaywas polled after it returnedPoll::Ready. WASM was producing a panic becausegloo_timers::future::TimeoutFuturepanic in this case.In this PR I also enable test cases under
teststo run in WASM.We discovered this bug while researching eigerco/lumina#256.