Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft add favicon #124

Merged
merged 29 commits into from
Sep 25, 2024
Merged

Ft add favicon #124

merged 29 commits into from
Sep 25, 2024

Conversation

Philimuhire
Copy link
Contributor

@Philimuhire Philimuhire commented Sep 12, 2024

PR Description
This PR adds a favicon next to the title of the webpage in the browser's tab.

Description of tasks that were expected to be completed
Add a favicon

How has this been tested?
. Clone the repo
. Checkout branch ft-add-favicon
. Run the project with npm run dev

Track PR (issue number & link)
Issue link : #115

Screenshoots

image

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atlp-devpulse-fn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 8:57am

@Philimuhire Philimuhire added DREAM DREAM TEAM Ready For Review Extra attention is needed labels Sep 13, 2024
@mugishaj092 mugishaj092 self-requested a review September 14, 2024 14:50
Copy link
Contributor

@mugishaj092 mugishaj092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codeclimate and rebase also logo is not visible
image

package.json Outdated Show resolved Hide resolved
public/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@hbapte hbapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done

@Prince-Kid Prince-Kid self-requested a review September 17, 2024 08:19
@Prince-Kid
Copy link
Contributor

Well Done

Copy link
Contributor

@Prince-Kid Prince-Kid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Contributor

@mugishaj092 mugishaj092 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far but this build file is not nessary

Copy link

codeclimate bot commented Sep 24, 2024

Code Climate has analyzed commit 8874ee2 and detected 0 issues on this pull request.

View more on Code Climate.

@mugishaj092 mugishaj092 self-requested a review September 24, 2024 11:11
@tysepa tysepa self-requested a review September 24, 2024 17:49
@mugishaj092 mugishaj092 added Ready For Merge and removed Ready For Review Extra attention is needed labels Sep 25, 2024
@Salim-54 Salim-54 merged commit 2f9b0ea into develop Sep 25, 2024
7 checks passed
Ishimwe7 pushed a commit that referenced this pull request Oct 10, 2024
* fix: remove placeholder property

* add favicon svg

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* add favicon svg

* resolved conflicts

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Philimuhire pushed a commit that referenced this pull request Oct 22, 2024
* Add Not Found Page

* Add Sign In Profile Picture

Ft-send-bulky-email (#61)

* new

* added a send email model

* email

* email

Co-authored-by: UmuhireJessie <86103578+UmuhireJessie@users.noreply.github.com>

TO be removed

fix: run the app

ft-superadmin-roles&permissions(superadmin can view members)

feat(ft-user-register): user should be able to create account

superAdmin register user

fix(routes): Add routes directory

add login page and add name field on user registration by superadmin

create program

bg: Added Loader

ft(): programs page

role & permission

implementation of delete role and permissions

ft():delete program

implementation of delete role and permissions

feature:Application form using Google Form

implementation of delete role and permissions

ft(): edit program

new changes

ft():Applicant Dashboard

add grading system form

feat(admin list applications):view applications

ft admin view applications

admin update status of candidate application

Feature github actions (#119)

* fix: remove placeholder property

* Have github actions setup with necessary jobs

* Have code climate errors removed

* Corrected codeclimate issues

* --ammend

* --ammend

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: Ndahimana Bonheur <ndahimana154@gmail.com>

* fix: remove placeholder property

* #103 Navigation fixed

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: Ndahimana Bonheur <ndahimana154@gmail.com>

Fix number can't be shared (#130)

Co-authored-by: Mugisha <mugisha@franks-MacBook-Pro.local>

* fix: remove placeholder property

* fix duplicate links

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

Ft minimize dashboard menu #110 (#140)

* fix: remove placeholder property

* ft minimize dashboard menu

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* Fix layout spacing between sidebar and main content in AdminLayout

* new

* Fix layout spacing between sidebar and main content in AdminLayout

* fix layout

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: Prince-Kid <mucyoprinc12@gmail.com>
Co-authored-by: Mucyo Prince <134399659+Prince-Kid@users.noreply.github.com>
Co-authored-by: Aime-Patrick <aimepatrick64@gmail.com>

* fix: remove placeholder property

* The built-in superadmin account cannot create a program

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

Ft shareable job post (#139)

* fix: remove placeholder property

* Ft():shareable job post page

* Feature: Adding shareable job post buttons

* Feature: Adding shareable job post buttons

* Feature: Adding shareable job post buttons

* fix codeclimate issue

* add gmail and fix telegram link

* add gmail sharing

* fix url sharing

* fix url

* fix url

* fix codeclimate

* applicant share application

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: dean-daryl <deandaryl7@gmail.com>
Co-authored-by: Bahati <admin@bahati.local>
Co-authored-by: uwituzeb <b.uwituze@alustudent.com>

Ft add favicon (#124)

* fix: remove placeholder property

* add favicon svg

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* add favicon svg

* resolved conflicts

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* added favicon

* removed unneccessary added port number

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

* resolved conflicts

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

Fix tel (#123)

* fix: remove placeholder property

* fix code & tell issue

* rebasing

* fix code issue

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

Fix/update trainee info (#137)

* add validations and work on edit

* ensure birthdate is correctly set in formData

* ensure all formData are populated correctly

* fix codeclimate issue

* update traineUpdate

* update traineUpdate

* update traineUpdate

* update traineUpdate

* update traineUpdate

* update traineUpdate

* fix traineUpdate

* add loader

* add sidebar link for trainee applicants

* add redirection after updating

* feature: improve trainee details page

* handling missing application info, also adding download functionality

* fixing error related to download and refactoring

* Update TrainneeDetails.tsx

* handling issues related to deployment

* Fix number can't be shared (#130)

Co-authored-by: Mugisha <mugisha@franks-MacBook-Pro.local>

* #102 sidebar links review (#128)

* fix: remove placeholder property

* fix duplicate links

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

* Ft minimize dashboard menu #110 (#140)

* fix: remove placeholder property

* ft minimize dashboard menu

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* Fix layout spacing between sidebar and main content in AdminLayout

* new

* Fix layout spacing between sidebar and main content in AdminLayout

* fix layout

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: Prince-Kid <mucyoprinc12@gmail.com>
Co-authored-by: Mucyo Prince <134399659+Prince-Kid@users.noreply.github.com>
Co-authored-by: Aime-Patrick <aimepatrick64@gmail.com>

* #118 fx: builtinSuperAdminCreateProgram (#126)

* fix: remove placeholder property

* The built-in superadmin account cannot create a program

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

* feature: improve trainee details page

* handling missing application info, also adding download functionality

* Update TrainneeDetails.tsx

* adding way to send email and other adjustments

* refining and fixing some issues

* Update webpack.config.js

* customizing way of sending email

* refactoring code to fix issue related to code climate

* fixing issue for deployment

* fixing issues related to refactoring

---------

Co-authored-by: MUGISHA Emmanuel <emmyzizo1@gmail.com>
Co-authored-by: Mugisha <mugisha@franks-MacBook-Pro.local>
Co-authored-by: ISHIMWE Jean Baptiste <ijbapte@gmail.com>
Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: ManziPatrick <144239912+ManziPatrick@users.noreply.github.com>
Co-authored-by: Prince-Kid <mucyoprinc12@gmail.com>
Co-authored-by: Mucyo Prince <134399659+Prince-Kid@users.noreply.github.com>
Co-authored-by: Aime-Patrick <aimepatrick64@gmail.com>
Co-authored-by: Niyonshuti Jean De Dieu <152473876+Jadowacu1@users.noreply.github.com>

fixes #168 auth and admin login (#169)

* feature: improve trainee details page (#172)

* handling missing application info, also adding download functionality

* fixing error related to download and refactoring

* Update TrainneeDetails.tsx

* handling issues related to deployment

* Fix number can't be shared (#130)

* #102 sidebar links review (#128)

* fix: remove placeholder property

* fix duplicate links

---------

* Ft minimize dashboard menu #110 (#140)

* fix: remove placeholder property

* ft minimize dashboard menu

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* Fix layout spacing between sidebar and main content in AdminLayout

* new

* Fix layout spacing between sidebar and main content in AdminLayout

* fix layout

---------

* #118 fx: builtinSuperAdminCreateProgram (#126)

* fix: remove placeholder property

* The built-in superadmin account cannot create a program

---------

* feature: improve trainee details page

* handling missing application info, also adding download functionality

* Update TrainneeDetails.tsx

* adding way to send email and other adjustments

* refining and fixing some issues

* Update webpack.config.js

* customizing way of sending email

* refactoring code to fix issue related to code climate

* fixing issue for deployment

* fixing issues related to refactoring

---------

Co-authored-by: MUREKEZI Ismael <110295158+Ismaelmurekezi@users.noreply.github.com>
Co-authored-by: MUGISHA Emmanuel <emmyzizo1@gmail.com>
Co-authored-by: Mugisha <mugisha@franks-MacBook-Pro.local>
Co-authored-by: ISHIMWE Jean Baptiste <ijbapte@gmail.com>
Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: ManziPatrick <144239912+ManziPatrick@users.noreply.github.com>
Co-authored-by: Prince-Kid <mucyoprinc12@gmail.com>
Co-authored-by: Mucyo Prince <134399659+Prince-Kid@users.noreply.github.com>
Co-authored-by: Aime-Patrick <aimepatrick64@gmail.com>

Ft search job post (#187)

* ft(Add search): Add entry search

* Will add user seach Job Functionalities --squashed commits

* single page to view and search Jobs

* will make jobs and search be on same page

* updating functionality

* Real time searching

---------

Co-authored-by: Jmukakalisa <j.mukakalis@alustudent.com>

154 crud application form (#167)

* Will add create application feature

* Will add update application form feature

* Will add view application form feature

* Will add dark mode card

* Will add create application feature

* Will add update application form feature

* Will add view application form feature

* Will add dark mode card

Add Verify Email (#179)

Co-authored-by: vegetason <irakozepaulin12@example.com>

ft(Add search): Add entry search (#136)

Co-authored-by: Jmukakalisa <j.mukakalis@alustudent.com>

Forget password   #147 (#178)

* fogetpassword

* ft-forget password

* reset and forget password

* reset and forget password

* reset and forget password

* reset and forget password

* reset password

* reset update background

* reset update background

* reset update background

* reset password

* reset password

* reset password

* reset password

* yarn.lock

* Ft search job post (#187)

* ft(Add search): Add entry search

* Will add user seach Job Functionalities --squashed commits

* single page to view and search Jobs

* will make jobs and search be on same page

* updating functionality

* Real time searching

---------

Co-authored-by: Jmukakalisa <j.mukakalis@alustudent.com>

* 154 crud application form (#167)

* Will add create application feature

* Will add update application form feature

* Will add view application form feature

* Will add dark mode card

* Will add create application feature

* Will add update application form feature

* Will add view application form feature

* Will add dark mode card

* Add Verify Email (#179)

Co-authored-by: vegetason <irakozepaulin12@example.com>

* resolve comflit

* resolve comflit

* resolve comflit

* resolve comflit

---------

Co-authored-by: Aime Brues <72033556+SHYAKA-Aime@users.noreply.github.com>
Co-authored-by: Jmukakalisa <j.mukakalis@alustudent.com>
Co-authored-by: MUGISHA Joseph <143373965+mugishaj092@users.noreply.github.com>
Co-authored-by: Irakoze Paulin <111436668+vegetason@users.noreply.github.com>
Co-authored-by: vegetason <irakozepaulin12@example.com>

Ft edit, publish and unpublish jobs (#189)

* fix: remove placeholder property

* fix code & tell issue

* will add ft for editing jobs

---------

Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>

Fix fault alerts (#182)

* correct error messages

* work on resolving fault alerts

remove a bug (#190)

Co-authored-by: vegetason <irakozepaulin12@example.com>

Admin dashboard (#181)

General search and filtration admin (#184)

* general-search-admin

* Will add results tab

general search updates

resolved conflicts

admin general search updates

fixing code climate issues

* resolving conflicts

---------

Co-authored-by: MUGISHA Joseph <143373965+mugishaj092@users.noreply.github.com>

* add applicant dashboard page

* add dashboard cards

* integrate with backend

* fetch all data from their respective queries

* remove console logs

* update cohort types and query

* fix routes

* fix code climate

* add graph

* fix chart

* delete yarn

* fix graph and login

* fix

* trigger

* revert

---------

Co-authored-by: uwituzeb <b.uwituze@alustudent.com>

Fix job Search (#199)

Co-authored-by: vegetason <irakozepaulin12@example.com>

* feature: improve trainee details page (#172)

* handling missing application info, also adding download functionality

* fixing error related to download and refactoring

* Update TrainneeDetails.tsx

* handling issues related to deployment

* Fix number can't be shared (#130)

* #102 sidebar links review (#128)

* fix: remove placeholder property

* fix duplicate links

---------

* Ft minimize dashboard menu #110 (#140)

* fix: remove placeholder property

* ft minimize dashboard menu

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard by icon and categorize into section

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* fix minimize dashboard scrollbar

* Fix layout spacing between sidebar and main content in AdminLayout

* new

* Fix layout spacing between sidebar and main content in AdminLayout

* fix layout

---------

* #118 fx: builtinSuperAdminCreateProgram (#126)

* fix: remove placeholder property

* The built-in superadmin account cannot create a program

---------

* feature: improve trainee details page

* handling missing application info, also adding download functionality

* Update TrainneeDetails.tsx

* adding way to send email and other adjustments

* refining and fixing some issues

* Update webpack.config.js

* customizing way of sending email

* refactoring code to fix issue related to code climate

* fixing issue for deployment

* fixing issues related to refactoring

---------

Co-authored-by: MUREKEZI Ismael <110295158+Ismaelmurekezi@users.noreply.github.com>
Co-authored-by: MUGISHA Emmanuel <emmyzizo1@gmail.com>
Co-authored-by: Mugisha <mugisha@franks-MacBook-Pro.local>
Co-authored-by: ISHIMWE Jean Baptiste <ijbapte@gmail.com>
Co-authored-by: ceelogre <sam.nishimwe@yahoo.com>
Co-authored-by: ManziPatrick <144239912+ManziPatrick@users.noreply.github.com>
Co-authored-by: Prince-Kid <mucyoprinc12@gmail.com>
Co-authored-by: Mucyo Prince <134399659+Prince-Kid@users.noreply.github.com>
Co-authored-by: Aime-Patrick <aimepatrick64@gmail.com>

revert changes from develop (#205)

fix:dev conflict issues (#207)

added preferences page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants