-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix token expired #218 #221
Open
ManziPatrick
wants to merge
3
commits into
develop
Choose a base branch
from
fix-token-exp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iChris-tian
approved these changes
Oct 22, 2024
berniceu
approved these changes
Oct 22, 2024
bahati10
approved these changes
Oct 22, 2024
MnorbertVii
approved these changes
Oct 23, 2024
Aime-Patrick
approved these changes
Oct 23, 2024
Code Climate has analyzed commit f4fa17c and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description: Implement Token Expiration After One Hour
This PR implements token expiration functionality that automatically logs out users after one hour of token issuance to enhance session security.
Tasks Completed:
Token Expiration Logic: Added a
TOKEN_ISSUED_TIME
field inlocalStorage
to track when the token was issued.Expiration Check: Implemented logic to check if the token has expired one hour (3600 seconds) after issuance.
Automatic Logout: If the token has expired, the user is logged out, localStorage is cleared, and the user is redirected to the login page with a session expiration message.
How Has This Been Tested?
Clone the repo.
Checkout the branch
ft-token-expiration
.Run
npm install
andnpm run dev
to start the app.Validate token expiration by waiting for one hour and checking if the session automatically logs out.
Test on various routes to ensure expired tokens trigger the logout flow.
Tracking Issue
Resolves: [Issue #218]
Screenshots
After token timeout