Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161: Skeleton Implementation #227

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

Ishimwe7
Copy link
Contributor

Description
This PR introduces skeleton loading components throughout the application to improve user experience by providing visual feedback during data fetching. These skeleton loaders mimic the structure of the final content, making the interface more intuitive and responsive while the content is loading.

Description of Task Completed

  • Implemented skeleton loading components across key areas of the application.
  • Skeleton loaders are designed to represent the final structure of the content, enhancing the visual feedback to users during loading times.
  • Integrated loaders with existing features to ensure a smooth transition when content is being fetched from the backend.

How to test this PR(locally)

  • Clone the repo and check out the branch ft-skeleton-implementation
  • Set up environment variables as indicated in .env.example
  • Run npm install followed by npm run dev
  • Test loading states in following areas:
    • Navigate through different sections
    • Observe skeleton animations during data fetching
    • Verify smooth transitions between states

Related Issue
#161

Screenshots

NavbarMembers

traineeApplicant

editApplicantInfo

trash

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atlp-devpulse-fn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 6:04am

Copy link
Contributor

@Ismaelmurekezi Ismaelmurekezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Ishimwe7

@Prince-Kid Prince-Kid self-requested a review October 24, 2024 10:54
Copy link
Contributor

@Prince-Kid Prince-Kid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job

@Ishimwe7 Ishimwe7 added Ready For Review Extra attention is needed DREAM DREAM TEAM labels Oct 24, 2024
@SaddockAime SaddockAime linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Contributor

@ncutixavier ncutixavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove all changes not related to the skeleton.
  • Please read well the task description, anything not related to your task remove it

Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit 9ef0c73 and detected 0 issues on this pull request.

View more on Code Climate.

@Ishimwe7
Copy link
Contributor Author

  • Remove all changes not related to the skeleton.
  • Please read well the task description, anything not related to your task remove it

done

@ncutixavier ncutixavier merged commit 6c492d5 into develop Oct 25, 2024
7 checks passed
@ncutixavier ncutixavier deleted the ft-skeleton-implementations branch October 25, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DREAM DREAM TEAM Ready For Review Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Skeleton
5 participants