-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#331 Improve invitation table pagination to be dynamic #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #337 +/- ##
==========================================
Coverage ? 17.24%
==========================================
Files ? 85
Lines ? 3160
Branches ? 913
==========================================
Hits ? 545
Misses ? 2605
Partials ? 10 ☔ View full report in Codecov by Sentry. |
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 2, 2024 15:03
e27724f
to
19635b5
Compare
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 3, 2024 15:37
19635b5
to
aa5adab
Compare
Oliviier-dev
added
Needs Reviews
A pull request need reviews to be merged
and removed
WIP
Work in progress
labels
Oct 4, 2024
Oliviier-dev
requested review from
GSinseswa721,
niyobertin,
jniyonkuru,
YvetteNyibuka,
Ndevu12,
Sophie20202 and
Yvan-David
October 4, 2024 06:10
niyobertin
approved these changes
Oct 4, 2024
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 6, 2024 03:15
aa5adab
to
3dcbeb7
Compare
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 6, 2024 12:58
3dcbeb7
to
0e9c64a
Compare
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 9, 2024 05:32
0e9c64a
to
e2a1401
Compare
1 task
B# Last command done (1 command done):
Oliviier-dev
force-pushed
the
ft-dynamic-invitation-pagination
branch
from
October 15, 2024 07:25
e2a1401
to
b82f35e
Compare
ceelogre
temporarily deployed
to
ft-dynamic-invitation-pagination - devpulse-backend PR #337
October 15, 2024 07:25
— with
Render
Destroyed
UwicyezaG
approved these changes
Oct 16, 2024
jniyonkuru
approved these changes
Oct 16, 2024
Oliviier-dev
added
ready for review
and removed
Needs Reviews
A pull request need reviews to be merged
labels
Oct 16, 2024
ncutixavier
approved these changes
Oct 17, 2024
ncutixavier
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR resolves the issue with fetching invitations using pagination.
Description of tasks that were expected to be completed
Functionality
When viewing invitations from the frontend, the pagination will be dynamic
How has this been tested?
In apollo studio, first log in the org with "andela" and proceed to log in an admin user with email: "devpulse@proton.me" and password: "Test@12345". After loggin in run the getAllInvitations query and specify the limit as well as offset in the variables.
PR Checklist:
Track PR
Trello Link (DP)
Screenshots (If appropriate)
(Images)