Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#331 Improve invitation table pagination to be dynamic #337

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Oliviier-dev
Copy link
Contributor

@Oliviier-dev Oliviier-dev commented Oct 2, 2024

PR Description

This PR resolves the issue with fetching invitations using pagination.

Description of tasks that were expected to be completed

  • Improve invitation table pagination to be dynamic

Functionality

When viewing invitations from the frontend, the pagination will be dynamic

How has this been tested?

In apollo studio, first log in the org with "andela" and proceed to log in an admin user with email: "devpulse@proton.me" and password: "Test@12345". After loggin in run the getAllInvitations query and specify the limit as well as offset in the variables.

PR Checklist:

  • Improve invitation table pagination to be dynamic

Track PR

Trello Link (DP)

Screenshots (If appropriate)

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@c99966a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/TableViewInvitationResolver.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #337   +/-   ##
==========================================
  Coverage           ?   17.24%           
==========================================
  Files              ?       85           
  Lines              ?     3160           
  Branches           ?      913           
==========================================
  Hits               ?      545           
  Misses             ?     2605           
  Partials           ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Oliviier-dev Oliviier-dev force-pushed the ft-dynamic-invitation-pagination branch from e2a1401 to b82f35e Compare October 15, 2024 07:25
@ceelogre ceelogre temporarily deployed to ft-dynamic-invitation-pagination - devpulse-backend PR #337 October 15, 2024 07:25 — with Render Destroyed
@Oliviier-dev Oliviier-dev added ready for review and removed Needs Reviews A pull request need reviews to be merged labels Oct 16, 2024
@ncutixavier ncutixavier merged commit 33546aa into develop Oct 17, 2024
3 checks passed
@ncutixavier ncutixavier deleted the ft-dynamic-invitation-pagination branch October 17, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants