-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#357 Refactor attendance handling to be processed server-side #358
Open
aimedivin
wants to merge
1
commit into
develop
Choose a base branch
from
fix-server-side-attendance
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 16, 2024 04:26
1b558df
to
0570a17
Compare
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 16, 2024 04:34
0570a17
to
0227d03
Compare
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 18, 2024 05:50
0227d03
to
032370b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #358 +/- ##
==========================================
Coverage ? 16.85%
==========================================
Files ? 88
Lines ? 3393
Branches ? 967
==========================================
Hits ? 572
Misses ? 2816
Partials ? 5 ☔ View full report in Codecov by Sentry. |
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 21, 2024 12:08
032370b
to
0ddc696
Compare
Open
aimedivin
changed the title
Refactor attendance handling to be processed server-side
#357 Refactor attendance handling to be processed server-side
Oct 22, 2024
aimedivin
requested review from
Calebgisa72,
elijahladdie,
igorihimbazwe,
kanu-cast,
Salim-54 and
rwemakevin
October 22, 2024 10:17
kanu-cast
approved these changes
Oct 22, 2024
rwemakevin
approved these changes
Oct 22, 2024
elijahladdie
approved these changes
Oct 22, 2024
igorihimbazwe
approved these changes
Oct 22, 2024
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 23, 2024 20:00
0ddc696
to
11c56c1
Compare
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 24, 2024 07:23
11c56c1
to
0a17944
Compare
aimedivin
force-pushed
the
fix-server-side-attendance
branch
from
October 25, 2024 07:49
0a17944
to
7fa4f8d
Compare
Calebgisa72
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR refactors the attendance handling logic to be processed server-side, ensuring a more secure and centralized approach. Additionally, the update includes logic to prevent any attendance week from being skipped.
Description of tasks that were expected to be completed
Functionality
How does this works, add some information that maybe needed in testing
How has this been tested?
git clone https://github.com/atlp-rwanda/atlp-pulse-bn.git cd atlp-pulse-bn git checkout fix-server-side-attendance npm i npm run dev
Track PR
#357