Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#579 Admin should be able to login after signup #362

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mpanoathos
Copy link
Contributor

@mpanoathos mpanoathos commented Oct 16, 2024

PR Description

This PR includes a fix of how admin can be able to login after signup in his/her respective organisation without any hindrance

Description of tasks that were expected to be completed

  1. Admin is only able to login in an organisation he/she belongs to.
  2. After signup admin is able to login without being requested to be added to program or cohort

How has this been tested?

  1. Clone your repository using git clone
  • Run the server npm run dev

  • Test it either on front end or using apollo graphql server

  1. Use this this link for testing :
  • Login using email:devpulse@proton.me , password :Test@12345,

  • Create a user with admin user role

  • signup that user

  • Login with the credentials you have already signed up

PR Checklist:

  • Task 1.
  • Task 2.
  • Task 3.
  • Task n.

Track PR

Trello Link (#579)

Screenshots (If appropriate)

Screenshot 2024-10-17 103227
Screenshot 2024-10-17 103244
Screenshot 2024-10-17 103417
Screenshot 2024-10-17 103432
Screenshot 2024-10-17 103454
Screenshot 2024-10-17 103505

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@a6fbfed). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/userResolver.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #362   +/-   ##
==========================================
  Coverage           ?   17.32%           
==========================================
  Files              ?       86           
  Lines              ?     3158           
  Branches           ?      913           
==========================================
  Hits               ?      547           
  Misses             ?     2601           
  Partials           ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpanoathos mpanoathos force-pushed the fix-admin-login branch 2 times, most recently from b9cfe53 to c0223e2 Compare October 16, 2024 14:01
@mpanoathos mpanoathos force-pushed the fix-admin-login branch 3 times, most recently from 56c2e2a to bbc8877 Compare October 17, 2024 08:09
@mpanoathos mpanoathos changed the title Admin should be able to login after signup #579 #579 Admin should be able to login after signup Oct 17, 2024
@mpanoathos mpanoathos added Needs Reviews A pull request need reviews to be merged and removed WIP Work in progress labels Oct 17, 2024
@mpanoathos mpanoathos self-assigned this Oct 17, 2024
@ceelogre ceelogre temporarily deployed to fix-admin-login - devpulse-backend PR #362 October 17, 2024 19:52 — with Render Destroyed
@ncutixavier ncutixavier merged commit d3f9075 into develop Oct 18, 2024
3 checks passed
@ncutixavier ncutixavier deleted the fix-admin-login branch October 18, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fighters Team Needs Reviews A pull request need reviews to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants