Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-update-docs #365

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix-update-docs #365

merged 1 commit into from
Oct 18, 2024

Conversation

Calebgisa72
Copy link
Contributor

PR Description

This PR solves an issue of not having which role to update while updating a document

Description of tasks that were expected to be completed

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.

Functionality

How does this works, add some information that maybe needed in testing

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

PR Checklist:

  • Task 1.
  • Task 2.
  • Task 3.
  • Task n.

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

(Images)

@Calebgisa72 Calebgisa72 added Needs Reviews A pull request need reviews to be merged steppers Steppers Team labels Oct 16, 2024
@Calebgisa72 Calebgisa72 self-assigned this Oct 16, 2024
@ceelogre ceelogre temporarily deployed to fix-update-docs - devpulse-backend PR #365 October 16, 2024 15:06 — with Render Destroyed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (develop@c99966a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/DocumentationResolvers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #365   +/-   ##
==========================================
  Coverage           ?   17.25%           
==========================================
  Files              ?       85           
  Lines              ?     3159           
  Branches           ?      912           
==========================================
  Hits               ?      545           
  Misses             ?     2604           
  Partials           ?       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elijahladdie elijahladdie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salim-54 Salim-54 merged commit 9ed6608 into develop Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Reviews A pull request need reviews to be merged steppers Steppers Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants