Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#404): Getting the Client's Ip Adress using request_ip package #376

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JacquelineTuyisenge
Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge commented Oct 23, 2024

PR Description

This PR retrieves the client IP Address using the request_ip package, ans also fixes the SuperAdmin Login

Description of tasks that were expected to be completed

  • this solves the issue, where the Ip address was not found when using deployed link, only was found using Local Host and it was causing the Login activities to display as null. but now we used the request_ip package that gets IP adress from and site
  • Login Error was found when login because logi Activities were passed on SuperAdmin's Profile. And Normally the Superadmin's Profile is unAvailable, so whe it first searched profile, it could not find it and that caused error while logging in.

To solve this: For Now I am passing the Loggin Actvivities to SuperAdmin'Profile.

Functionality

to test this:

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • I installed the `request_ip` package
  • I added the backend preview link in fronted dev as Backend url
  • I run frontend server, logged in and clicked on login activities

    PR Checklist:

    • Task 1.
    • Task 2.
    • Task 3.
    • Task n.

    Track PR

    Trello Link (#DP-?)

    Screenshots (If appropriate)

    (Images)

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@5d39ddd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/userResolver.ts 0.00% 10 Missing ⚠️
src/context.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #376   +/-   ##
==========================================
  Coverage           ?   17.25%           
==========================================
  Files              ?       86           
  Lines              ?     3210           
  Branches           ?      919           
==========================================
  Hits               ?      554           
  Misses             ?     2651           
  Partials           ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacquelineTuyisenge JacquelineTuyisenge self-assigned this Oct 23, 2024
@JacquelineTuyisenge JacquelineTuyisenge added bug Something isn't working WIP Work in progress Nova labels Oct 23, 2024
@JacquelineTuyisenge JacquelineTuyisenge added Needs Reviews A pull request need reviews to be merged and removed WIP Work in progress labels Oct 23, 2024
@Salim-54
Copy link

Salim-54 commented Oct 23, 2024

Skeleton UI is needed before rendering the list table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Reviews A pull request need reviews to be merged Nova
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants