-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#404): Getting the Client's Ip Adress using request_ip package #376
Open
JacquelineTuyisenge
wants to merge
1
commit into
develop
Choose a base branch
from
fix-getClintIp-for-LoginActivities
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #376 +/- ##
==========================================
Coverage ? 17.25%
==========================================
Files ? 86
Lines ? 3210
Branches ? 919
==========================================
Hits ? 554
Misses ? 2651
Partials ? 5 ☔ View full report in Codecov by Sentry. |
JacquelineTuyisenge
added
Needs Reviews
A pull request need reviews to be merged
and removed
WIP
Work in progress
labels
Oct 23, 2024
Tuyisenge2
approved these changes
Oct 23, 2024
musabehonore
approved these changes
Oct 23, 2024
shebz2023
approved these changes
Oct 23, 2024
Skeleton UI is needed before rendering the list table |
shema-surge
approved these changes
Oct 23, 2024
JacquelineTuyisenge
force-pushed
the
fix-getClintIp-for-LoginActivities
branch
from
October 27, 2024 07:24
645e8cd
to
617c635
Compare
JacquelineTuyisenge
force-pushed
the
fix-getClintIp-for-LoginActivities
branch
from
October 27, 2024 07:55
617c635
to
bbd05f0
Compare
JacquelineTuyisenge
force-pushed
the
fix-getClintIp-for-LoginActivities
branch
from
October 28, 2024 09:50
bbd05f0
to
0c221d0
Compare
MugemaneBertin2001
approved these changes
Oct 28, 2024
JacquelineTuyisenge
force-pushed
the
fix-getClintIp-for-LoginActivities
branch
from
October 28, 2024 09:55
0c221d0
to
ee6cbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR retrieves the client IP Address using the request_ip package, ans also fixes the SuperAdmin Login
Description of tasks that were expected to be completed
To solve this: For Now I am passing the Loggin Actvivities to SuperAdmin'Profile.
Functionality
to test this:
npm i
to install new added packageHow has this been tested?
Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
PR Checklist:
Track PR
Trello Link (#DP-?)
Screenshots (If appropriate)
(Images)