Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#374 implement fetch trainees such that any admin can see all trainees #379

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Yvan-David
Copy link
Contributor

@Yvan-David Yvan-David commented Oct 24, 2024

PR Description

Please include a brief description of the pull request you want to raise.

  • implement fetch trainees such that any admin can see all trainees

Description of tasks that were expected to be completed

List all the tasks and sub-tasks that were assigned to you or that you assigned yourself. Make sure you check evey completed task.

Functionality

How does this works, add some information that maybe needed in testing

Email Role password
devpulse@proton.me admin Test@12345
irankundayvan2020+1@gmail.com admin Test@12345

How has this been tested?

  1. Login using this link https://devpulse-backend-pr-379.onrender.com/
  2. Use data provided to login in two different accounts (make sure you use different browsers)
  3. Visit Trainees page on trainees table for the two accounts and check if they have the same trainees in the table
  4. you can add a trainee on one count and check if he will be in the trainees table of the other account

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

PR Checklist:

  • Task 1.
  • Task 2.
  • Task 3.
  • Task n.

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

ADMIN1

image

ADMIN 2

image

(Images)

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@3138d6b). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #379   +/-   ##
==========================================
  Coverage           ?   17.23%           
==========================================
  Files              ?       86           
  Lines              ?     3209           
  Branches           ?      918           
==========================================
  Hits               ?      553           
  Misses             ?     2651           
  Partials           ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.vscode/settings.json Outdated Show resolved Hide resolved
@ncutixavier
Copy link
Contributor

Your commit message is wrong

- implement get Trainees such that  any admin can see all trainees
@Yvan-David Yvan-David force-pushed the fix-fetchTrainees-byOrganisation-374 branch from 84f6b89 to c3a4dc8 Compare October 24, 2024 15:27
@ceelogre ceelogre temporarily deployed to fix-fetchTrainees-byOrganisation-374 - devpulse-backend PR #379 October 24, 2024 15:27 — with Render Destroyed
@ncutixavier ncutixavier merged commit cfe810e into develop Oct 25, 2024
3 checks passed
@ncutixavier ncutixavier deleted the fix-fetchTrainees-byOrganisation-374 branch October 25, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fighters Team Needs Reviews A pull request need reviews to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants