Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trainee attendance #385

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix trainee attendance #385

wants to merge 3 commits into from

Conversation

Calebgisa72
Copy link
Contributor

@Calebgisa72 Calebgisa72 commented Oct 25, 2024

PR Description

This PR makes a query to get trainee attendance, it's type def and its implementation

Description of tasks that were expected to be completed

Fixing trainee attendance to be used in the updated frontend design

Functionality

How does this works, add some information that maybe needed in testing

How has this been tested?

Please describe the tests that you ran to verify your functionalities. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

PR Checklist:

  • Make the type defs of trainee attendance.
  • Make trainee attendance query.
  • Making the trainee attendance query implementation.

Track PR

Trello Link (#DP-?)

Screenshots (If appropriate)

(Images)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.24373% with 256 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@5d39ddd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/resolvers/attendance.resolvers.ts 5.92% 143 Missing ⚠️
src/utils/cron-jobs/team-jobs.ts 10.76% 58 Missing ⚠️
src/utils/getDateForDays.ts 8.57% 32 Missing ⚠️
src/resolvers/team.resolvers.ts 8.33% 11 Missing ⚠️
src/resolvers/cohort.resolvers.ts 14.28% 6 Missing ⚠️
src/resolvers/userResolver.ts 0.00% 4 Missing ⚠️
src/models/attendance.model.ts 50.00% 1 Missing ⚠️
src/resolvers/coordinatorResolvers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #385   +/-   ##
==========================================
  Coverage           ?   16.85%           
==========================================
  Files              ?       88           
  Lines              ?     3393           
  Branches           ?      975           
==========================================
  Hits               ?      572           
  Misses             ?     2816           
  Partials           ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Calebgisa72 Calebgisa72 added Needs Reviews A pull request need reviews to be merged steppers Steppers Team labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Reviews A pull request need reviews to be merged steppers Steppers Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants