Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rating trainee #512

Merged
merged 5 commits into from
Sep 27, 2024
Merged

fix rating trainee #512

merged 5 commits into from
Sep 27, 2024

Conversation

igorihimbazwe
Copy link
Member

@igorihimbazwe igorihimbazwe commented Sep 24, 2024

PR Description

This pr fixes the bug which was on getting trainee data

Description of tasks that were expected to be completed

this pr fixed the fetching of trainee data who is. going to be rated and also prevent user to rate a trainee who is dropped out

How has this been tested?

Clone the project fror frontend https://github.com/atlp-rwanda/atlp-pulse-fn.git switch to fx-rating-trainee branch.
for back end clone this https://github.com/atlp-rwanda/atlp-pulse-bn.git switch to fx-rating-trainee branch

include all env variables for front end then install all dependencies npm install and run with npm run dev
Login as coordinator and try to rate dropped trainee

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 11:26am

Copy link
Contributor

@aimedivin aimedivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorihimbazwe , Disable 'Add Rating' button for dropped Trainees
image

@Salim-54 Salim-54 merged commit 1b58a2a into develop Sep 27, 2024
6 checks passed
@ceelogre ceelogre deleted the fx-rating-trainee branch September 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants