-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rating trainee #512
Merged
Merged
fix rating trainee #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorihimbazwe
requested review from
pacifiquemboni,
kanu-cast,
elijahladdie,
aimedivin and
Calebgisa72
September 24, 2024 20:05
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igorihimbazwe
requested review from
hatfelicien
and removed request for
pacifiquemboni
September 27, 2024 05:52
aimedivin
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igorihimbazwe , Disable 'Add Rating' button for dropped Trainees
elijahladdie
approved these changes
Sep 27, 2024
kanu-cast
approved these changes
Sep 27, 2024
Calebgisa72
approved these changes
Sep 27, 2024
aimedivin
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pr fixes the bug which was on getting trainee data
Description of tasks that were expected to be completed
this pr fixed the fetching of trainee data who is. going to be rated and also prevent user to rate a trainee who is dropped out
How has this been tested?
Clone the project fror frontend
https://github.com/atlp-rwanda/atlp-pulse-fn.git
switch tofx-rating-trainee
branch.for back end clone this
https://github.com/atlp-rwanda/atlp-pulse-bn.git
switch tofx-rating-trainee
branchinclude all env variables for front end then install all dependencies
npm install
and run withnpm run dev
Login as coordinator and try to rate dropped trainee