Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skeleton loader #415 #516

Merged
merged 3 commits into from
Oct 2, 2024
Merged

skeleton loader #415 #516

merged 3 commits into from
Oct 2, 2024

Conversation

Dawaic6
Copy link
Contributor

@Dawaic6 Dawaic6 commented Sep 26, 2024

PR Description

This PR reconstructs the skeleton loaders across the entire application to better match the respective page layouts. The goal is to enhance the user experience by providing more accurate visual placeholders that align with the design and content of each page while the data is loading.

Description of tasks that were expected to be completed

  • Ensured consistency in loader colors, sizes, and spacing across all pages.
  • Made all skeleton loaders responsive to adapt well to different screen sizes.

How has this been tested?

Manual Testing: Verified each page's skeleton loaders to ensure they align with the respective page layout and design

  • Navigated through each page to check that loaders appear correctly while data is being fetched.
  • Checked that the loaders are responsive and adapt well to different screen sizes.
  • Ensured no existing functionality was broken by the new loaders.

Screenshots (If appropriate)

  • calender
image - **organisation** image - ttl page image # Please check this Checklist before you submit your PR:
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@Dawaic6 Dawaic6 added bug Something isn't working Work In Progress labels Sep 26, 2024
@Dawaic6 Dawaic6 self-assigned this Sep 26, 2024
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 2:34pm

@Salim-54 Salim-54 merged commit 266d7ed into develop Oct 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Need Reviews Nova Team Nova
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants