Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#578 Improving search invitation to listern to typing event #591

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Ndevu12
Copy link
Contributor

@Ndevu12 Ndevu12 commented Oct 17, 2024

PR Description

Improving search invitation to listen to typing events and filter according to the typed value.

Description of tasks that were expected to be completed

  • Implemented a debounce mechanism to handle search input and avoid unnecessary API calls.
  • Updated the handleSearch function to handle empty search queries properly.
  • Ensured that the search functionality filters invitations based on the typed value.
  • Refactored the code to handle errors without displaying toast notifications.

How has this been tested?

clone this repostory , cd into it
run npm install to install deopendencies and npm run dev to start the server or use this preview link

login in as damin with the following credentials
emai : devpulse@proton.me
password: Test@12345

  • Start the application and navigate to the invitation page.
  • Type a search query in the search input field and observe the filtered results.
  • Delete the search query and verify that the invitations are cleared and no errors are displayed.
  • Simulate an error scenario and ensure that the error is handled without displaying a toast notification.

Number of Commits

1

Screenshots (If appropriate)

Screenshot 2024-10-18 at 13 23 31 Screenshot 2024-10-18 at 13 23 44

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

@Ndevu12 Ndevu12 added the Fighters Team Fighters label Oct 17, 2024
@Ndevu12 Ndevu12 self-assigned this Oct 17, 2024
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 0:35am

@Ndevu12 Ndevu12 linked an issue Oct 17, 2024 that may be closed by this pull request
@ncutixavier ncutixavier merged commit b7cb194 into develop Oct 21, 2024
6 checks passed
@ncutixavier ncutixavier deleted the fx-search-invitations branch October 21, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve invitaion search bar
5 participants