Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#575 Move client-side attendance logic to server #596

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aimedivin
Copy link
Contributor

@aimedivin aimedivin commented Oct 21, 2024

PR Description

This PR moves the attendance tracking logic from the client-side to the server-side to improve performance, scalability, and data security.

Description of tasks that were expected to be completed

  • Migrated client-side attendance tracking logic to the server.
  • Created new API endpoints to handle attendance-related requests.
  • A TTL is now able to record an attendance
  • Updated front-end code to communicate with the new server endpoints.
  • Ensured that the changes do not negatively impact any other functionality.

How has this been tested?

  • Clone this repository and navigate to the project directory
  • Ensure You have backend service running and set your .env file using .env.example.
  git clone https://github.com/atlp-rwanda/atlp-pulse-fn.git
  cd atlp-pulse-fn
  git checkout fix-attendance-logic
  npm I
  npm run test
  or
  npm run dev
  • Login in with valid TTL or coordinator credentials
  • Navigate to attendance page

Number of Commits

  • 1 Commit

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:46am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attendance data should be calculated on the server not client
4 participants