Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#595 Improve the dark mode skeleton to match the dark design #598

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

UwicyezaG
Copy link
Contributor

@UwicyezaG UwicyezaG commented Oct 22, 2024

PR Description

This PR improves the dark mode skeletons on the invitation page to better align with the overall dark design of the application.

Description of tasks that were expected to be completed

  • Changed the Skeleton colors of cards and table match dark design.
  • Ensured the Text box matches on both side.
  • Ensure responsiveness are maintained

How has this been tested?

Clone this repo, cd into it ,checkout the branch ft-improve-invitation-darkSkeleton then run :

npm install : to install dependences
npm run dev to start the server

or use this link: https://metron-devpulse-git-ft-improve-invitation-darkskeleton-metron.vercel.app/

log in with credential:
Email: devpulse@proton.me
password: Test@12345

Number of Commits

1 Commit

Screenshots (If appropriate)

Invitation Page:

  • Dark mode skeleton
    image
    image

  • Light mode skeleton
    image
    image

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generate no warnings
  • My test coverage meet the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 9:19am

@ncutixavier ncutixavier merged commit f08afd4 into develop Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants