Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#404 add skeleton loader on login activities table #600

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

JacquelineTuyisenge
Copy link
Contributor

@JacquelineTuyisenge JacquelineTuyisenge commented Oct 24, 2024

PR Description

This pull request adds a skeleton loader for the login activities table,

Description of tasks that were expected to be completed

  • Implemented a skeleton loader using react-loading-skeleton for the login activities table.
  • Updated the LoginActivitiesTable component to conditionally render the skeleton loader during data fetching.
  • Ensured that the skeleton loader matches the structure of the actual table for a seamless transition once data is loaded.
  • Verified that the skeleton loader displays correctly on both desktop and mobile views.

How has this been tested?

  • The following tests were performed to verify the functionality:
    • Visual Testing: Verified that the skeleton loader appears correctly when the data is loading and disappears when the data is fully loaded.
    • Mobile Responsiveness: Checked that the skeleton loader displays correctly on small screens.

Instructions to reproduce:

  1. Checkout into branch , make sure that in your frontend env you have BACKEND_URL=https://devpulse-backend-pr-376.onrender.com and Login
  2. go to your profile picture
  3. Click on login Activities, skeletons will show
  4. change themes and screen width too to see the responsiveness

Number of Commits

The number of commits for this PR is 1.

Please check this Checklist before you submit your PR:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My code generates no warnings
  • My test coverage meets the set test coverage threshold
  • There are no vulnerabilities
  • There are no conflicts with the base branch

Screenshots (If appropriate)

Screenshot 2024-10-24 112703

Screenshot 2024-10-24 112613

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metron-devpulse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 10:44am

Copy link
Contributor

@RWEMAREMY RWEMAREMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Salim-54 Salim-54 merged commit 4321d94 into develop Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants