-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed testsetup to make sure database is cleaned before running eve… #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
niyobern
force-pushed
the
102-bug-tests-failing
branch
from
May 27, 2024 09:52
107a041
to
8c84fdd
Compare
niyobern
force-pushed
the
102-bug-tests-failing
branch
4 times, most recently
from
May 27, 2024 10:41
c644b24
to
dad86cb
Compare
niyobern
force-pushed
the
102-bug-tests-failing
branch
from
May 27, 2024 11:54
dad86cb
to
da8f2b2
Compare
Dawaic6
approved these changes
May 27, 2024
niyibi250
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good
wayneleon1
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
dushimeemma
approved these changes
May 27, 2024
ambroisegithub
pushed a commit
that referenced
this pull request
May 27, 2024
ambroisegithub
pushed a commit
that referenced
this pull request
May 27, 2024
ambroisegithub
pushed a commit
that referenced
this pull request
May 27, 2024
ambroisegithub
pushed a commit
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the setup for our tests. The tests were previously failing not due to issues in the code being tested, but due to problems in the test setup.
Description of Task to be completed?
beforeAllHook
function intestSetup.ts
How should this be manually tested?
To test the new test setup:
npm run test
Any background context you want to provide?
The tests were previously failing due to issues in the test setup, not in the code being tested. This PR addresses the test setup issues to ensure our tests run correctly.
What are the relevant jira ticket?