Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed testsetup to make sure database is cleaned before running eve… #103

Merged
merged 1 commit into from
May 27, 2024

Conversation

niyobern
Copy link
Collaborator

@niyobern niyobern commented May 27, 2024

What does this PR do?

This PR fixes the setup for our tests. The tests were previously failing not due to issues in the code being tested, but due to problems in the test setup.

Description of Task to be completed?

  • Investigate the beforeAllHook function in testSetup.ts
  • Revise the sequence of operations in the test setup to ensure a proper setup for our tests
  • Ensure all tests start with a clean, predictable state

How should this be manually tested?

To test the new test setup:

  1. Run the test suite with npm run test
  2. Observe that the tests no longer fail due to setup issues

Any background context you want to provide?

The tests were previously failing due to issues in the test setup, not in the code being tested. This PR addresses the test setup issues to ensure our tests run correctly.

What are the relevant jira ticket?

@niyobern niyobern linked an issue May 27, 2024 that may be closed by this pull request
@niyobern niyobern self-assigned this May 27, 2024
@niyobern niyobern added the bug Something isn't working label May 27, 2024 — with GitHub Codespaces
@niyobern niyobern force-pushed the 102-bug-tests-failing branch 4 times, most recently from c644b24 to dad86cb Compare May 27, 2024 10:41
@niyobern niyobern requested a review from niyibi250 May 27, 2024 13:18
Copy link
Collaborator

@niyibi250 niyibi250 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good

Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dushimeemma dushimeemma merged commit 8193ee8 into develop May 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Tests failing
5 participants