Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#116 Fix failing create review function #117

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

jkarenzi
Copy link
Collaborator

what does this PR do?

  • This PR fixes the error in the create review function. It was failing because there was no validation

Description of the task to be completed

  • Add validation in the create review function, before processing the request body
  • Update swagger documentation
  • Write tests to cover added lines

How can this be manually tested?

  • By making requests to the endpoint

What are the relevant pivotal trackers?

-add validation before processing data

[Fixes #116]
@jkarenzi jkarenzi added the bug Something isn't working label May 30, 2024
@jkarenzi jkarenzi added this to the Order Management milestone May 30, 2024
@jkarenzi jkarenzi self-assigned this May 30, 2024
-add validation before processing data

[Fixes #116]
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (1b0a766) to head (9b8f6ad).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
+ Coverage    90.72%   90.77%   +0.05%     
===========================================
  Files           46       47       +1     
  Lines         1186     1193       +7     
  Branches       131      132       +1     
===========================================
+ Hits          1076     1083       +7     
  Misses          93       93              
  Partials        17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@jkarenzi jkarenzi added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label May 31, 2024
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@dushimeemma dushimeemma merged commit f7e2d7f into develop May 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants