Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to Our News Letter #123

Closed
wants to merge 5 commits into from
Closed

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jun 25, 2024

Tasks comleted

  • Implement subscribe Endpoint for use to Keep In touch
  • Implement appropriate error handling and responses
  • Write appropriate unit tests
  • Write appropriate documentation for the resulting endpoint

Resolved test for Momo

added configuritions on lint files
added wishlist test
@13XAVI 13XAVI linked an issue Jun 25, 2024 that may be closed by this pull request
@13XAVI 13XAVI added the enhancement New feature or request label Jun 25, 2024
@13XAVI 13XAVI self-assigned this Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.63%. Comparing base (52a7f9e) to head (a8cb29a).

Files Patch % Lines
src/controller/subscribeController.ts 96.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #123      +/-   ##
===========================================
+ Coverage    90.46%   90.63%   +0.16%     
===========================================
  Files           61       63       +2     
  Lines         1562     1601      +39     
  Branches       167      171       +4     
===========================================
+ Hits          1413     1451      +38     
- Misses         126      127       +1     
  Partials        23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@13XAVI 13XAVI force-pushed the 122-subsribe-to-our-news branch 3 times, most recently from e24e4e5 to eefe1c6 Compare June 25, 2024 15:36
@13XAVI 13XAVI closed this Jun 25, 2024
@13XAVI 13XAVI deleted the 122-subsribe-to-our-news branch June 25, 2024 17:43
@13XAVI 13XAVI mentioned this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subsribe to Our News
2 participants