Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing category icons #131

Merged

Conversation

niyobern
Copy link
Collaborator

@niyobern niyobern commented Jul 2, 2024

Title

Add icon Column to Category Table

Description

This pull request introduces a new icon column to the category table in our database. The purpose of this addition is to enhance the visual representation of categories in our application by associating each category with a unique icon. All areas of the codebase that create or update category records have been updated to include this new field.

Changes

  • Added a new icon column to the category table in the database schema.
  • Updated all INSERT and UPDATE queries for the category table to include the icon field.
  • Updated the controller logic to process the icon field during category creation and updates.
  • Adjusted the API responses to include the icon field where category data is returned.

Testing

  • Manual testing was performed to ensure that categories can be successfully created and updated with icons through the UI.
  • Automated tests have been updated to cover the new icon field in category creation and update scenarios.

Additional Notes

  • The icons are expected to be stored as URLs pointing to the icon svg.

@niyobern niyobern linked an issue Jul 2, 2024 that may be closed by this pull request
@niyobern niyobern force-pushed the 130-feat-adding-an-icon-column-to-the-category-relation branch from c6e94cc to 66d1543 Compare July 2, 2024 22:36
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (60a10d5) to head (43d546e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #131      +/-   ##
===========================================
+ Coverage    87.34%   87.35%   +0.01%     
===========================================
  Files           65       65              
  Lines         1675     1677       +2     
  Branches       179      179              
===========================================
+ Hits          1463     1465       +2     
  Misses         189      189              
  Partials        23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyobern niyobern self-assigned this Jul 2, 2024
@niyobern niyobern added enhancement New feature or request backend Good for newcomers labels Jul 2, 2024
Dawaic6
Dawaic6 previously approved these changes Jul 3, 2024
wayneleon1
wayneleon1 previously approved these changes Jul 3, 2024
@niyobern niyobern dismissed stale reviews from wayneleon1 and Dawaic6 via 43d546e July 8, 2024 12:02
@niyobern niyobern force-pushed the 130-feat-adding-an-icon-column-to-the-category-relation branch from 66d1543 to 43d546e Compare July 8, 2024 12:02
@niyobern niyobern added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 8, 2024
@dushimeemma dushimeemma merged commit 0897559 into develop Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers enhancement New feature or request Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat - Adding An icon column to the category relation
5 participants