Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redirect frontend url #133

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix redirect frontend url #133

merged 1 commit into from
Jul 3, 2024

Conversation

wayneleon1
Copy link
Contributor

@wayneleon1 wayneleon1 commented Jul 3, 2024

What does this PR do ?

This PR addresses an issue with the frontend URL redirection. The incorrect redirect URL was causing navigation issues for users. This fix ensures that users are redirected to the correct URL, improving the overall user experience.

Changes:

  • Corrected the URL in the frontend redirection logic.
  • Verified that all existing redirect scenarios function as expected.

What relevant pivot track

#135

@wayneleon1 wayneleon1 added the backend Good for newcomers label Jul 3, 2024
@wayneleon1 wayneleon1 self-assigned this Jul 3, 2024
@wayneleon1 wayneleon1 linked an issue Jul 3, 2024 that may be closed by this pull request
1 task
@wayneleon1 wayneleon1 added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (60a10d5) to head (47ebdf8).

Files Patch % Lines
src/routes/auth-routes.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #133   +/-   ##
========================================
  Coverage    87.34%   87.34%           
========================================
  Files           65       65           
  Lines         1675     1675           
  Branches       179      179           
========================================
  Hits          1463     1463           
  Misses         189      189           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for merge!!!

@dushimeemma dushimeemma merged commit 9ba5d84 into develop Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Redirect Frontend URL
6 participants