Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix bug in search functionality #149

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

jkarenzi
Copy link
Collaborator

@jkarenzi jkarenzi commented Jul 16, 2024

What does this PR do?

  • This PR implements a fix for search and filter endpoints

Description of the task to be completed?

  • Fix search functionality such that a buyer can search by keyword, price range, category, rating or sort order
  • Update swagger documentation
  • Add pagination

How can this be manually tested?

  • By making requests to the api/v1/buyer/search endpoint with different search criteria

What are the relevant pivotal trackers/story id?

@jkarenzi jkarenzi self-assigned this Jul 16, 2024
@jkarenzi jkarenzi force-pushed the fix-search-#148 branch 6 times, most recently from 25f2260 to 54bb256 Compare July 16, 2024 17:08
- fix bugs in search functionality
- add new search criteria
- add pagination

[Fixes #148]
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.39%. Comparing base (77b44b8) to head (085e703).

Files Patch % Lines
src/controller/searchProducts.ts 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #149      +/-   ##
===========================================
- Coverage    86.49%   86.39%   -0.10%     
===========================================
  Files           65       65              
  Lines         1755     1757       +2     
  Branches       191      193       +2     
===========================================
  Hits          1518     1518              
  Misses         212      212              
- Partials        25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkarenzi jkarenzi added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 16, 2024
@dushimeemma dushimeemma merged commit dd394da into develop Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants