Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendors name and product category in best selling response #152

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

EddyShimwa
Copy link
Contributor

What does this PR do?

  • This is PR allows the admin to retrive the vendors names and product category when fetching the best selling products

How it was before

image

How it is now

image

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.37%. Comparing base (734e842) to head (a17b42d).

Files Patch % Lines
src/controller/productController.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #152      +/-   ##
===========================================
- Coverage    86.38%   86.37%   -0.01%     
===========================================
  Files           65       65              
  Lines         1755     1754       -1     
  Branches       193      193              
===========================================
- Hits          1516     1515       -1     
  Misses         212      212              
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

13XAVI
13XAVI previously approved these changes Jul 17, 2024
wayneleon1
wayneleon1 previously approved these changes Jul 17, 2024
@EddyShimwa EddyShimwa added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 18, 2024
@dushimeemma dushimeemma merged commit 2a1f852 into develop Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants