Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the Admin should get more details about coupons #159

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

wayneleon1
Copy link
Contributor

@wayneleon1 wayneleon1 commented Jul 19, 2024

Description:
This PR addresses the need for admins to have access to more detailed information about coupons within the platform. Previously, the coupon details were limited, making it challenging for admins to manage and review coupon usage effectively. This update includes the following enhancements:

  • Extended Coupon Information: Admins can now view comprehensive details about each coupon, including:
  • - Coupon code
  • - Discount value
  • - Expiry date
  • - Applicable products/categories
  • - Created date and creator's information

@wayneleon1 wayneleon1 added the backend Good for newcomers label Jul 19, 2024
@wayneleon1 wayneleon1 self-assigned this Jul 19, 2024
@wayneleon1 wayneleon1 linked an issue Jul 19, 2024 that may be closed by this pull request
@wayneleon1 wayneleon1 added the WIP Work In Progress label Jul 19, 2024
@wayneleon1 wayneleon1 force-pushed the fix-get-more-details-coupons-#158 branch 3 times, most recently from d95c9b8 to ca43016 Compare July 20, 2024 17:27
@wayneleon1 wayneleon1 force-pushed the fix-get-more-details-coupons-#158 branch from ca43016 to 455a0d7 Compare July 20, 2024 17:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 96.62921% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.30%. Comparing base (189d16f) to head (6763f61).

Files Patch % Lines
src/controller/couponController.ts 95.65% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
- Coverage    86.33%   86.30%   -0.04%     
===========================================
  Files           65       65              
  Lines         1764     1774      +10     
  Branches       193      194       +1     
===========================================
+ Hits          1523     1531       +8     
- Misses         214      216       +2     
  Partials        27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wayneleon1 wayneleon1 added Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager and removed WIP Work In Progress labels Jul 20, 2024
jkarenzi
jkarenzi previously approved these changes Jul 20, 2024
niyobern
niyobern previously approved these changes Jul 20, 2024
EddyShimwa
EddyShimwa previously approved these changes Jul 20, 2024
@wayneleon1 wayneleon1 dismissed stale reviews from EddyShimwa, niyobern, and jkarenzi via 43373e0 July 20, 2024 20:42
@wayneleon1 wayneleon1 force-pushed the fix-get-more-details-coupons-#158 branch from 455a0d7 to 43373e0 Compare July 20, 2024 20:42
13XAVI
13XAVI previously approved these changes Jul 20, 2024
@wayneleon1 wayneleon1 force-pushed the fix-get-more-details-coupons-#158 branch from 43373e0 to 6fa9788 Compare July 20, 2024 20:44
@wayneleon1 wayneleon1 force-pushed the fix-get-more-details-coupons-#158 branch from 97deb1f to 6763f61 Compare July 21, 2024 06:49
@wayneleon1 wayneleon1 requested a review from 13XAVI July 21, 2024 08:42
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!!!

@dushimeemma dushimeemma merged commit 8b17f90 into develop Jul 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Get more details for Coupons
8 participants