Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ch linting and formatting #20

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Ch linting and formatting #20

merged 3 commits into from
Apr 25, 2024

Conversation

EddyShimwa
Copy link
Contributor

What does this PR do?

Setting up Linting and Formating

###Description of Task to be completed?

  • Set up ESLint to enforce coding standards and identify potential errors
  • Configure Prettier to automatically format code according to predefined rules

How should this be manually tested?

After cloning the repo, run the follwoing commands

  • npm install To install dependencies
  • npm run lint To run Es-Lint
  • npm run format To format with Prettier

Any background context you want to provide?

  • Linting Files are in root directory

What are the relevant pivotal trackers?

#9

@EddyShimwa EddyShimwa added backend Good for newcomers chore Define what a chore is labels Apr 25, 2024
wayneleon1

This comment was marked as off-topic.

Sign in to view

wayneleon1
wayneleon1 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me 👍

@wayneleon1 wayneleon1 linked an issue Apr 25, 2024 that may be closed by this pull request
Linting and Formatting #9
Closed
2 tasks
ambroisegithub
ambroisegithub approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's All great!!!

@jkarenzi
Copy link
Collaborator

All good!

Habinezajanvier
Habinezajanvier approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Habinezajanvier Habinezajanvier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Habinezajanvier Habinezajanvier merged commit 6589dea into develop Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habinezajanvier Habinezajanvier Habinezajanvier approved these changes

@wayneleon1 wayneleon1 wayneleon1 approved these changes

@ambroisegithub ambroisegithub ambroisegithub approved these changes

@jkarenzi jkarenzi jkarenzi approved these changes

@bertrandshema bertrandshema Awaiting requested review from bertrandshema

@Dawaic6 Dawaic6 Awaiting requested review from Dawaic6

Assignees
No one assigned
Labels
backend Good for newcomers chore Define what a chore is
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linting and Formatting
5 participants
@EddyShimwa @jkarenzi @Habinezajanvier @wayneleon1 @ambroisegithub