-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#34 Add Role Based Access Control #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jkarenzi
requested review from
Habinezajanvier,
niyobern,
wayneleon1,
EddyShimwa and
ambroisegithub
May 3, 2024 11:54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Rease PR with only one commit not 37
-define roles and permissions for vendors and buyers -assign roles and permissions to users during registration or profile update -enforce role-based access control throughout the application -write comprehensive unit tests [Delivers #34]
-integrate role based access control into user registration [Delivers #34]
-integrate role based access control into user registration [Delivers #34]
Habinezajanvier
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds role based access control to the project
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
Vendor permissions
Buyer permissions
Admin permissions
manage_users
manage_roles
manage_products
manage orders
manage_categories
manage_shipping
manage_payments
view_reports
checkRole middleware takes in an array of roles that are allowed to access a certain route
checkPermission middleware takes in a string (permission), that is required to access a certain route
e.g checkPermissions('manage_cart')
The above middleware rely on authentication middleware(middleware that will check if a user is logged in)
What are the relevant pivotal trackers?
#34