Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft authenticate user #29 #47

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented May 6, 2024

Pull Request Description

This Pull Request is made for Registered user on Dynamite-Ecomerce-be to be Authenticated by the app . to prevent unknown users in the system. user can be able to sign in to the e-commerce platform using email and password so that he /she can access his/her account and its respective features. User Login endPoint is safe to authenticate the user's credentials and provide appropriate responses and error handling.

Description of Task to be completed:

  • Implement a user sign-in API endpoint
  • Validate user input (email and password)
  • Retrieve the user record from the database based on the provided email
  • Verify the provided password against the securely stored password hash
  • Generate and return an authentication token (e.g., JSON Web Token) upon successful sign-in
  • Return appropriate success or error responses
  • Implement input sanitization

To use the Code

Related Issues

Definition of Done

  • User sign-in API endpoint is implemented and functional
  • User input validation and sanitization measures are in place
  • User credentials are securely verified against stored data
  • Authentication tokens are generated and returned upon successful sign-in
  • Appropriate success and error responses are returned
  • Unit tests are written and passing
  • Code adheres to coding standards and best practices
  • API documentation is updated

@13XAVI 13XAVI added documentation Improvements or additions to documentation backend Good for newcomers labels May 6, 2024
@13XAVI 13XAVI added this to the Authentication & RBAC milestone May 6, 2024
@13XAVI 13XAVI self-assigned this May 6, 2024
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to have onlyone commit

@13XAVI 13XAVI force-pushed the ft-Authenticate-user-#29 branch 4 times, most recently from a5d97fc to c136ffd Compare May 8, 2024 11:08
@13XAVI 13XAVI requested a review from ambroisegithub May 8, 2024 12:33
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks Good with Me!!!

Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me

register user test

register user testing fix

register user testing fix

register user testing fix

Authentication for User

Added slint changes

removed  mocha

 added new features

 added new features

Solved comflicts

changed file

added changes

added new Test

added new Test

resolved test cases

resolved test cases
@13XAVI 13XAVI force-pushed the ft-Authenticate-user-#29 branch from f3a50e8 to 1b2c59f Compare May 8, 2024 12:38
@Habinezajanvier Habinezajanvier merged commit dabe813 into develop May 8, 2024
3 checks passed
@13XAVI 13XAVI linked an issue May 8, 2024 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: User Sign In with Email and Password
6 participants