Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchProducts #80

Merged
merged 1 commit into from
May 27, 2024
Merged

searchProducts #80

merged 1 commit into from
May 27, 2024

Conversation

Dawaic6
Copy link
Contributor

@Dawaic6 Dawaic6 commented May 21, 2024

This pull request introduces a new feature that allows buyers to search products by typing keyword, category, productName, sort using search tools

Implemented Features:

  • endpoint for search functions
  • Unit test on search
  • swagger document for search endpoint

Definition of Done:

  • Endpoint of search functions (Buyer can search a product)
  • Unit test for search which passing
  • Complete swagger document for search endpoint

Related Issues:
#37
#38

To use the Code

Screenshot

-for test
image
-for swagger
image

@Dawaic6 Dawaic6 added the backend Good for newcomers label May 21, 2024
@Dawaic6 Dawaic6 added this to the Product Management milestone May 21, 2024
@Dawaic6 Dawaic6 self-assigned this May 21, 2024
@Dawaic6 Dawaic6 force-pushed the ft-search-product-#56 branch 4 times, most recently from 713070a to 877dc33 Compare May 27, 2024 15:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes are missing coverage. Please review.

Please upload report for BASE (develop@d66c4f1). Learn more about missing BASE report.

Files Patch % Lines
src/controller/searchProducts.ts 91.30% 2 Missing ⚠️
src/middlewares/validateSearchParams.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #80   +/-   ##
==========================================
  Coverage           ?   89.52%           
==========================================
  Files              ?       39           
  Lines              ?      983           
  Branches           ?      116           
==========================================
  Hits               ?      880           
  Misses             ?       89           
  Partials           ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dawaic6 Dawaic6 requested a review from niyibi250 May 27, 2024 18:18
@Dawaic6 Dawaic6 added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label May 27, 2024
Copy link
Contributor

@wayneleon1 wayneleon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@dushimeemma dushimeemma merged commit 48b2d73 into develop May 27, 2024
2 checks passed
@wayneleon1 wayneleon1 linked an issue May 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Buyer should be able to search a product
6 participants