Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buyer should be able to manage cart #83

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

wayneleon1
Copy link
Contributor

@wayneleon1 wayneleon1 commented May 22, 2024

What does this PR do?

This pull request implements the functionality for buyers to add or remove items from their shopping cart.

Description of Task to be completed?

  • Implement an endpoint where a buyer can add new items to their cart
  • Implement an endpoint where a buyer can remove existing items from their cart
  • Implement appropriate error handling and responses
  • Write appropriate unit tests
  • Write appropriate documentation for the resulting endpoints

How should this be manually tested?

Checkout branch ft-manage-cart-#77
Install packages, and run npm run dev

Screenshoot

API documentation for the resulting endpoint is completed

Screenshot 2024-05-22 at 11 10 25

Unit tests are written and passing

Screenshot 2024-05-22 at 10 53 55

@wayneleon1 wayneleon1 added the backend Good for newcomers label May 22, 2024
@wayneleon1 wayneleon1 added this to the Checkout Management milestone May 22, 2024
@wayneleon1 wayneleon1 linked an issue May 22, 2024 that may be closed by this pull request
5 tasks
@wayneleon1 wayneleon1 force-pushed the ft-manage-cart-#77 branch 2 times, most recently from 250f2ae to 31989ed Compare May 22, 2024 09:29
@wayneleon1 wayneleon1 changed the title Mananage cart Buyer should be able to manage cart May 22, 2024
@wayneleon1 wayneleon1 added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label May 22, 2024
13XAVI
13XAVI previously approved these changes May 22, 2024
ambroisegithub
ambroisegithub previously approved these changes May 22, 2024
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great Job!!!

Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Looks good for Me!!!

EddyShimwa
EddyShimwa previously approved these changes May 23, 2024
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

niyobern
niyobern previously approved these changes May 23, 2024
src/routes/buyerRoutes.ts Show resolved Hide resolved
@jkarenzi jkarenzi requested a review from EddyShimwa May 23, 2024 15:18
ambroisegithub
ambroisegithub previously approved these changes May 23, 2024
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Looks Cool for me!!!

@jkarenzi jkarenzi self-requested a review May 23, 2024 15:26
jkarenzi
jkarenzi previously approved these changes May 23, 2024
jkarenzi
jkarenzi previously approved these changes May 23, 2024
niyobern
niyobern previously approved these changes May 23, 2024
bertrandshema
bertrandshema previously approved these changes May 23, 2024
Copy link
Contributor

@bertrandshema bertrandshema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@jkarenzi jkarenzi dismissed stale reviews from bertrandshema, niyobern, and themself via 4ec921d May 23, 2024 18:02
Copy link
Contributor

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Looks cool for me!!!

Copy link
Contributor

@13XAVI 13XAVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Copy link
Collaborator

@dushimeemma dushimeemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🔥

@dushimeemma dushimeemma merged commit 376b23e into develop May 24, 2024
3 checks passed
bertrandshema pushed a commit that referenced this pull request May 24, 2024
updating code coverall badges

created a new branch for solving emails (#90)

* created a new branch for solving emails

* ignored emails folder

Implemented product availability get and update (#74)

Buyer should be able to manage cart (#83)

* feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): swagger documentation

-add swagger documentation for all cart related endpoints

[Delivers #77]

implementing unit tests

chande status code of 422 to 409

updates cart rotes '

fix minor bugs in test configuration

* rebase from develop

---------

Co-authored-by: jkarenzi <j.karenzi@alustudent.com>

Recover passowrd feature

Adding the recover password features which includes controlers

Removing rebasing errors

Fix Test coverage Issues

Fix Test coverage Issues
bertrandshema pushed a commit that referenced this pull request May 24, 2024
updating code coverall badges

created a new branch for solving emails (#90)

* created a new branch for solving emails

* ignored emails folder

Implemented product availability get and update (#74)

Buyer should be able to manage cart (#83)

* feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): swagger documentation

-add swagger documentation for all cart related endpoints

[Delivers #77]

implementing unit tests

chande status code of 422 to 409

updates cart rotes '

fix minor bugs in test configuration

* rebase from develop

---------

Co-authored-by: jkarenzi <j.karenzi@alustudent.com>

Recover passowrd feature

Adding the recover password features which includes controlers

Removing rebasing errors

Fix Test coverage Issues

Fix Test coverage Issues
dushimeemma pushed a commit that referenced this pull request May 24, 2024
* Update README.md (#78)

updating code coverall badges

created a new branch for solving emails (#90)

* created a new branch for solving emails

* ignored emails folder

Implemented product availability get and update (#74)

Buyer should be able to manage cart (#83)

* feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): buyer should be able to manage cart

-buyer can add new items to cart
-buyer can remove items from cart
-buyer can update quantity in existing item in cart

[Delivers #77]

feat(manage-cart): swagger documentation

-add swagger documentation for all cart related endpoints

[Delivers #77]

implementing unit tests

chande status code of 422 to 409

updates cart rotes '

fix minor bugs in test configuration

* rebase from develop

---------

Co-authored-by: jkarenzi <j.karenzi@alustudent.com>

Recover passowrd feature

Adding the recover password features which includes controlers

Removing rebasing errors

Fix Test coverage Issues

Fix Test coverage Issues

* Coverage Error Fixing

---------

Co-authored-by: Rurangwa Leo <88591087+wayneleon1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Good for newcomers Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Guest/Buyer should be able to add items to cart
8 participants