Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added About us Page #122

Merged
merged 1 commit into from
Jul 24, 2024
Merged

added About us Page #122

merged 1 commit into from
Jul 24, 2024

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jul 23, 2024

What does this PR do?

  • This PR implements the About page

Description of the tasks to be completed

  • Implement About us ui components
  • Write appropriate unit tests

Related issue

#119

How can be tested

image

@13XAVI 13XAVI linked an issue Jul 23, 2024 that may be closed by this pull request
2 tasks
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for dynamite-frontend ready!

Name Link
🔨 Latest commit b86a860
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/66a0a9b5beeee900084e8ba5
😎 Deploy Preview https://deploy-preview-122--dynamite-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.45%. Comparing base (39665c2) to head (b86a860).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #122      +/-   ##
===========================================
+ Coverage    75.31%   75.45%   +0.14%     
===========================================
  Files          104      105       +1     
  Lines        11549    11616      +67     
  Branches       709      709              
===========================================
+ Hits          8698     8765      +67     
  Misses        2849     2849              
  Partials         2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@13XAVI 13XAVI force-pushed the 119-feature-implement-about-us branch from 2d796fd to 9f6d714 Compare July 23, 2024 13:31
Copy link
Collaborator

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Looks Good for merge!!!

@13XAVI 13XAVI force-pushed the 119-feature-implement-about-us branch 2 times, most recently from 6379cee to 9d5aae9 Compare July 23, 2024 13:56
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@13XAVI 13XAVI self-assigned this Jul 23, 2024
@13XAVI 13XAVI force-pushed the 119-feature-implement-about-us branch from 9d5aae9 to b86a860 Compare July 24, 2024 07:13
@13XAVI 13XAVI added the Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager label Jul 24, 2024
@dushimeemma dushimeemma merged commit a81ebd7 into develop Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-End Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Implement About Us
8 participants