Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Display Products in the Dashboard #77

Closed

Conversation

niyibi250
Copy link
Contributor

@niyibi250 niyibi250 commented Jul 9, 2024

What does this PR do?

Implement product display components, integrate with Redux for state management, add pagination controls, and write unit tests for product management in the vendor dashboard.

Description of Task to be completed?

As a vendor, this PR aims to display a list of products in the dashboard, fetch product data from the backend API, integrate state management with Redux Toolkit, implement pagination controls, and ensure robust unit test coverage.

How should this be manually tested?

- Fetch and Display Products:

  • Ensure products are fetched and displayed in a table/grid format.
  • Verify the layout and responsiveness using TailwindCSS.

- Pagination Controls:

Test pagination functionality to navigate through the product list.
Confirm correct display of pagination state.

- State Management:

  • Check loading indicators during data fetch.
  • Validate error handling if data fetch fails.

- Unit Tests:

  • Run Jest/Testing Library tests to verify data fetching, state management, and component functionality.
  • Mock API responses and Redux actions to simulate different scenarios.

Any background context you want to provide?

This PR is part of enhancing vendor dashboard functionality to improve inventory management by providing a clear view of product listings with robust state management and testing.

What are the relevant pivotal tracker/Trello stories?

#78 (comment)

#65 (comment)

Screenshots (if appropriate)

Screenshot 2024-07-09 134713

Screenshot 2024-07-09 134540

Questions:

Any feedback or suggestions on the implementation approach are welcome!

wayneleon1 and others added 5 commits July 9, 2024 12:53
rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

fix index error

fix loading same routes error

fix loading same routes error

write tests

write tests
rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

fix index error

fix loading same routes error

fix loading same routes error

write tests

write tests
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for dynamite-frontend ready!

Name Link
🔨 Latest commit f00c489
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/668d20b0ba67a50008145bb7
😎 Deploy Preview https://deploy-preview-77--dynamite-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.76336% with 258 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (e63c50e) to head (f00c489).

Files Patch % Lines
src/components/Dashboard/Table.tsx 11.38% 249 Missing ⚠️
src/features/Dashboard/dashboardProductsSlice.ts 83.67% 8 Missing ⚠️
tailwind.config.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
- Coverage    88.33%   82.98%   -5.35%     
===========================================
  Files           44       48       +4     
  Lines         3224     3733     +509     
  Branches       223      239      +16     
===========================================
+ Hits          2848     3098     +250     
- Misses         372      631     +259     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyibi250 niyibi250 closed this Jul 9, 2024
@niyibi250 niyibi250 deleted the 68-implementing-DisplayProducts-in-the-dashboard branch July 9, 2024 14:59
@niyibi250 niyibi250 restored the 68-implementing-DisplayProducts-in-the-dashboard branch July 9, 2024 14:59
@niyibi250 niyibi250 deleted the 68-implementing-DisplayProducts-in-the-dashboard branch July 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants