Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement shop page #95

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Feat: Implement shop page #95

merged 1 commit into from
Jul 17, 2024

Conversation

jkarenzi
Copy link
Collaborator

@jkarenzi jkarenzi commented Jul 16, 2024

What does this PR do?

  • This PR implements the shop page and all related functionalities

Description of the task to be completed?

  • Implement shop page UI
  • Implement search and filter functionality
  • Implement pagination

How can this be manually tested?

  • By accessing the shop page and testing searching by different criteria

Screenshots

Screenshot 2024-07-16 200603 mob bom q2

What are the relevant pivotal trackers/story id?

@jkarenzi jkarenzi self-assigned this Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for dynamite-frontend ready!

Name Link
🔨 Latest commit 6527316
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/6697a03d6e350e0008690bd2
😎 Deploy Preview https://deploy-preview-95--dynamite-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 66.50246% with 272 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (9fba487) to head (6527316).

Files Patch % Lines
src/pages/Shop.tsx 59.76% 270 Missing ⚠️
tailwind.config.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #95      +/-   ##
===========================================
- Coverage    88.09%   84.96%   -3.13%     
===========================================
  Files           62       64       +2     
  Lines         4677     5489     +812     
  Branches       337      373      +36     
===========================================
+ Hits          4120     4664     +544     
- Misses         553      821     +268     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkarenzi jkarenzi linked an issue Jul 16, 2024 that may be closed by this pull request
3 tasks
@jkarenzi jkarenzi added ready for review The PR is ready for review to be mergrd and removed ready for review The PR is ready for review to be mergrd labels Jul 16, 2024
@jkarenzi jkarenzi added the ready for review The PR is ready for review to be mergrd label Jul 17, 2024
@ambroisegithub
Copy link
Collaborator

It's looking good for merge

@jkarenzi jkarenzi force-pushed the ft-shop-page-#90 branch 2 times, most recently from 19e9b6c to e4e7262 Compare July 17, 2024 10:37
- implement shop page ui components
- implement search and filter functionality

[Delivers #90]
Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@13XAVI 13XAVI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try object fit to control image size in cards so that they may be uquivalent

@dushimeemma dushimeemma merged commit f299402 into develop Jul 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-End ready for review The PR is ready for review to be mergrd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Implement shop page
6 participants