Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Patient notifications #228

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

mr3nz1
Copy link
Contributor

@mr3nz1 mr3nz1 commented Jul 19, 2024

What does this Pull Request do?

Allows the user to receive realtime notifications about different occurrences or actions

Description

  • Notification upon booking
  • Notifcation upon cancellation of booking
  • Notification upon completion of booking
  • Notification up sign in

@mr3nz1 mr3nz1 added the Feature Feature issues label Jul 19, 2024
@mr3nz1 mr3nz1 added this to the Integrate Key App Features milestone Jul 19, 2024
@mr3nz1 mr3nz1 self-assigned this Jul 19, 2024
@mr3nz1 mr3nz1 linked an issue Jul 19, 2024 that may be closed by this pull request
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (ca4e979) to head (8f69704).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #228   +/-   ##
========================================
  Coverage    72.22%   72.22%           
========================================
  Files            3        3           
  Lines           18       18           
  Branches         3        3           
========================================
  Hits            13       13           
  Misses           5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@23nosurrend 23nosurrend force-pushed the ft-patient-notifications branch 2 times, most recently from 59a701c to 6891d27 Compare July 22, 2024 13:39
@23nosurrend 23nosurrend self-assigned this Jul 22, 2024
@23nosurrend 23nosurrend requested review from Irirwanirira, Paccyfic and munezeromicha and removed request for Irirwanirira July 22, 2024 13:40
Copy link

gitguardian bot commented Jul 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13077695 Triggered Stream Keys 8f69704 eas.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mr3nz1 mr3nz1 force-pushed the ft-patient-notifications branch 2 times, most recently from 3e292ae to 8696017 Compare July 23, 2024 10:46
    *ft(booking):add FlutteWave payment method
    *ft: allow user to end chats and leave a review
    *ft: patient notification context
    *feature: populate initial notifications and add new ones upon being added to the db
    *ft: fetched notifications and reworked on the notifications screen and notification Listing component
    *fix: device notification on notification creation
    *rf: refactored some erros
    *ft(notifications):add logic to insert notifications on every key action
    *ft(notifications):add logic to insert notifications on every booking
Copy link
Contributor

@Irirwanirira Irirwanirira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link
Contributor

@mukunzidd mukunzidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukunzidd mukunzidd merged commit c3f9a3a into develop Aug 7, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Patient Notifications
5 participants