This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Issue #114 handle ctags -n jumping to symbol
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symbols-view expects there to be patterns in `tags` files. This is the default behavior when running ctags (you can also explictly set it with the -F, or --excmd=pattern options). When running ctags with the number option (-n or --excmd=number), e.g ctags -R -n, numbers are used instead of patterns to identify lines. This package should expect and accept both formats. To determine which format a tag uses, check if tag.pattern and tag.lineNumber represent the same number. If so create a Point based on line number instead of pattern. `node-ctags` populates the tag.pattern parameter with the stringified lineNumber if `ctags -n` is run. When a tag has a pattern instead of a lineNumber, tag.LineNumber defaults to 0, and pattern will not be compares unless it is a line containing only a number, so will almost always return False. An additional test fixture was added for tags generated using the `ctags -R -n`.
mshenfield
force-pushed
the
issue-114-dont-rely-on-pattern-to-choose-line
branch
from
a186434
to
fd77e38
Compare
|
I believe this would also close #92 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbols-view expects there to be patterns in
tagsfiles. This is the default behavior when running ctags (you can also explictly set it with the -F, or --excmd=pattern options). When running ctags with the number option (-n or --excmd=number), e.g ctags -R -n, numbers are used instead of patterns to identify lines.This package should expect and accept both formats. To determine which format a tag uses, check if tag.pattern and tag.lineNumber represent the same number. If so create a Point based on line number instead of pattern.
node-ctagspopulates the tag.pattern parameter with the stringified lineNumber ifctags -nis run. When a tag has a pattern instead of a lineNumber, tag.LineNumber defaults to 0, and pattern will not be compares unless it is a line containing only a number, so will almost always return False.An additional test fixture was added for tags generated using the
ctags -R -n.