This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add puppet syntax support #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently puppet ctags generated via:
--langdef=Puppet
--langmap=Puppet:.pp
--regex-Puppet=/^class[ \t]*([:a-zA-Z0-9_\-]+)[ \t]*/\1/c,class/
--regex-Puppet=/^node[ \t]*([a-zA-Z0-9_"'\.\-]+)[ \t]*/\1/n,node/
--regex-Puppet=/^site[ \t]*([a-zA-Z0-9_"'\.\-]+)[ \t]*/\1/s,site/
--regex-Puppet=/^define[ \t]*([:a-zA-Z0-9_\-]+)[ \t]*/\1/d,definition/
--regex-Puppet=/^ *([a-zA-Z:_]+) *\{ *(.*) *:/\1[\2]/r,resource/
--regex-Puppet=/^ *(@[a-zA-Z:_]+) *\{ *(.*) *:/\1[\2]/v,virtual_resource/
--regex-Puppet=/^ *([A-Z][a-zA-Z0-9_:]+) *\{/\1/f,default/
now if one highlights symbol: 'user::foo` the best this module would do is pick up 'user' module and not the 'user::foo' module. This fix is supposed to fix that. not tested
|
Thanks for the contribution @droopy4096! Can you checkout my question in the issue you opened /cc #244 (comment)? Also, as mentioned in the |
|
sorry I'm temporarily away from my puppet environment... I'll post an update soon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
currently symbols-view has a special case for ruby notation (':'-separated) however it fails with Puppet notation ('::') - ruby's solution has been extended to provide puppet support
Alternate Designs
Alternatively there should be a map of language and word separators that could be extended by user. but implementation of such feature is beyond my current abilities in JS
Benefits
Puppet ctags will work as expected
Possible Drawbacks
none
Applicable Issues
#244