[preview] Pull Request to bump blead to 7.1.0 #181

atoomic · 2020-07-31T20:06:32Z

This pull request bumps the Perl version to 7.1.0 with some incremental changes:

Devel-PPPort: Bump to upstream
version: use PERL_VERSION compare macros
hreads: use PERL_VERSION compare macros
Storable: use PERL_COMPARE macros
Update Perl version to 7.0.0
Update Perl version to 7.1.0

Note that in order to provide backward compatibility with XS distributions, PERL_REVISION, PERL_VERSION and PERL_SUBVERSION are frozen at 5.255.255 (view patchlevel.h)

We are now instead using some semantic versioning macros: PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH

It's recommended to use the compare functions PERL_VERSION_EQ, PERL_VERSION_LT... instead of a direct access to these macros.

jkeenan · 2020-07-31T23:01:13Z

@atoomic, This is a p.r. from one branch in your repository to branch blead in the same repository. How does blead in this repository correspond to blead in https://github.com/Perl/perl5?

Thank you very much.
Jim Keenan

jkeenan · 2020-07-31T23:04:00Z

@atoomic, @toddr : If this p.r. ultimately makes its way to Perl 5 blead, does it in any way affect how I and (hopefully) others will work in pursuit of the objectives on our roadmap, the next of which is Objective 2?

Thank you very much.
Jim Keenan

atoomic · 2020-08-01T01:27:21Z

@jkeenan blead in this repo points to the state blead was in Perl5 repo a few years ago

atoomic · 2020-08-01T01:28:57Z

@jkeenan this PR once merged will not impact the work you are doing for alpha.
All objectives you have defined are valid and should be pursue like you planned.

dist/threads/threads.xs

dist/Storable/Storable.xs

Porting/bump-perl-version

leonerd · 2020-08-01T11:22:34Z

Porting/config.sh

+api_revision='7'
+api_subversion='0'
+api_version='1'


Is there any reason we're keeping these at their "old" names, rather than renaming them to api_version_{major,minor,patch} ?

Backwards compatibility. This looks like exactly the thing Perl-Toolchain-Gang/ExtUtils-MakeMaker#358 needed. Generally speaking we can't remove %Config keys.

Yes I would like to tackle these as a following task: patchlevel, subversion, api_*... macros are legacy
I think @ether is right, we want to remove them from core and let Devel-PPPort provide the backward compatibility layer. But this seems to me a follow up task and should not be part of this initial bump to 7.1.0.

Porting/pod_lib.pl

configpm

ext/Hash-Util/lib/Hash/Util.pm

patchlevel.h

leonerd · 2020-08-01T11:41:57Z

regen/feature.pl

-for ('default', sort grep /\.\d[02468]/, keys %feature_bundle) {
-    $::bundle = ":$_";
-    $::feature = join ' ', @{$feature_bundle{$_}};
+foreach my $bundle ('default', sort grep /\.\d*[02468]\z/a, keys %feature_bundle) {


The \z in here looks wrong. It will skip the "5.9.5" three-component one.

you are right about the \z but removing it will have no effects
note that 5.9.5 bundle is currently not listed in feature.pm
view https://metacpan.org/pod/feature#FEATURE-BUNDLES
are you saying that this is a bug in blead and we should fix it?
Do you still think \z should be removed? I'm good with both options

toke.c

uconfig.h

uconfig.sh

rjbs · 2020-08-01T13:42:42Z

Did read. Apart from a few things already mentioned, I had only a whitespace nit or two, so: 👍🏽

dist/Devel-PPPort/t/ppphtest.t

khwilliamson · 2020-08-02T13:36:39Z

On 8/2/20 2:14 AM, H.Merijn Brand wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In dist/Devel-PPPort/t/ppphtest.t <#181 (comment)>: > @@ -721,7 +721,7 @@ my %p; my $fail = 0; for ***@***.***) { my($name, $flags) = /^(\w+)(?:\s+\[(\w+(?:,\s+\w+)*)\])?$/ or $fail++; - exists $p{$name} and $fail++; + { exists $p{$name} and $fail++; } As a single change, this looks weird and confusing, certainly because the surrounding lines do not use an extra scope for the same construct. As Devel::PPPort is hard enough to maintain, I'd indeed like to see the code as non-complex as possible and drop the extra scope, but I would not consider it a blocker. —

I'll have another PR for D:P today

atoomic · 2020-08-03T03:00:14Z

failures noticed on windows

Test Summary Report
-------------------
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/min_perl_version.t                  : 5)
  Failed tests:  3, 5, 7, 9, 12
  Non-zero exit status: 5
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/postamble.t                         1)
  Failed test:  4
  Non-zero exit status: 1
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/prereq.t                            : 8)
  Failed tests:  4-10, 13
  Non-zero exit status: 8
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/several_authors.t                    2)
  Failed tests:  3, 6
  Non-zero exit status: 2
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/vstrings.t                          : 14)
  Failed tests:  11, 13, 15, 29, 39, 41, 43, 45, 47, 49
                51, 53, 55, 57
  Non-zero exit status: 14
sv_last_five_version../cpan/ExtUtils-MakeMaker/t/writemakefile_args.t                : 10)
  Failed tests:  4-5, 16, 18, 22, 26, 29, 32, 34, 36
  Non-zero exit status: 10
sv_last_five_version../ext/IPC-Open3/t/IPC-Open3.t                                   )
  TODO passed:   25
sv_last_five_version../lib/Config.t                                                  4)
  Failed tests:  7-8, 11-12
sv_last_five_versionFiles=2679, Tests=1088463, 1279 wallclock secs (81.58 usr +  7.97 sys = 89.55 CPU)
Result: FAIL

Use new core PERL_VERSION compare macros in vxs.inc When bumping version which this change we would need to make sure to use the last version of ppport.h

To provide backward compatibility with XS code PERL_REVISION, PERL_VERSION and PERL_SUBVERSION are frozen at 5.255.255 - view patchlevel.h This is introducing new Perl semantic versioning macros: PERL_VERSION_MAJOR, PERL_VERSION_MINOR, PERL_VERSION_PATCH It's recommended to use the compare functions PERL_VERSION_EQ, PERL_VERSION_LT... instead of a direct access to the `VERSION` macros.

toddr requested review from xsawyerx and toddr July 31, 2020 20:10

atoomic force-pushed the blead_to_710-PR branch from 54f3373 to 9d7dbb7 Compare July 31, 2020 20:10

atoomic changed the title ~~Setup of Pull Request to bump blead to 7.1.0~~ Dry Run Pull Request to bump blead to 7.1.0 Jul 31, 2020

atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from fa6b0cf to 77b11c8 Compare July 31, 2020 21:20

toddr force-pushed the blead_to_710-PR branch from dbcf846 to 23dfe56 Compare July 31, 2020 21:51

atoomic force-pushed the blead_to_710-PR branch from 23dfe56 to ae0cf47 Compare July 31, 2020 21:52

toddr force-pushed the blead_to_710-PR branch 2 times, most recently from cf6e07a to 89096dd Compare July 31, 2020 22:08

atoomic force-pushed the blead_to_710-PR branch 2 times, most recently from 2d608be to d4575b2 Compare July 31, 2020 22:37

atoomic requested a review from jkeenan July 31, 2020 22:47

Leont reviewed Aug 1, 2020

View reviewed changes

dist/threads/threads.xs Outdated Show resolved Hide resolved

Leont reviewed Aug 1, 2020

View reviewed changes

dist/Storable/Storable.xs Outdated Show resolved Hide resolved