-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store attachment as single entry #277
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also remove audb.Dependencies.attachment_files
and add instead audb.Dependencies.attachment_ids
and audb.Dependencies.attachments
. Can you also add this to the description of the pull request.
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
Closes #275
As discussed in #275 it is sufficient to store the path of the attachment in the dependency file. This applies the necessary changes.
This basically changes the entry for an attached folder
path/to/folder
with IDattachment
and the filespath/to/folder/f1.txt
andpath/to/folder/sub/f2.txt
from:to:
In addition,
audb.Dependencies.attachment_files
is removed and insteadaudb.Dependencies.attachment_ids
andaudb.Dependencies.attachments
are added.I will leave some comments in the code to make it easier to follow the changes.