Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use numpy<2.0.0 for older pandas versions #431

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jun 17, 2024

We just finished #430 and added tests for older pandas versions, but a few hours ago numpy released version 2.0.0, which does not work with pandas==2.0.3. As numpy is not automatically downgraded when installing pandas==2.0.3, I downgrade it manually now.

Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the numpy release 2 too and was surprised.
I will approve this as this merely retains compatibility.

@hagenw hagenw merged commit 839d86e into main Jun 19, 2024
10 checks passed
@hagenw hagenw deleted the fix-numpy-in-tests branch June 19, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants