Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: update ruff and codespell #451

Merged
merged 2 commits into from
Oct 31, 2024
Merged

TST: update ruff and codespell #451

merged 2 commits into from
Oct 31, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Oct 31, 2024

This updates ruff and codespell in the pre-commit config to its latest versions (which I think we should do once a year).

All tests are running fine with the newer versions, even though ruff have introduced some breaking changes.

Summary by Sourcery

Update the pre-commit configuration to use the latest versions of ruff and codespell, ensuring compatibility with their latest features and changes.

Build:

  • Update ruff to version 0.7.0 in the pre-commit configuration.
  • Update codespell to version 2.3.0 in the pre-commit configuration.

Copy link

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

This PR updates two pre-commit hooks (ruff and codespell) to their latest versions. Ruff is updated from v0.1.8 to v0.7.0, and codespell is updated from v2.2.4 to v2.3.0. Despite ruff having some breaking changes in these versions, all tests are passing successfully.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update pre-commit hook versions
  • Update ruff from v0.1.8 to v0.7.0
  • Update codespell from v2.2.4 to v2.3.0
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Since this is a major version update for ruff (0.1.8 -> 0.7.0), please confirm that you've tested the pre-commit hooks locally to verify they work as expected.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit 1d8ab57 into main Oct 31, 2024
8 checks passed
@hagenw hagenw deleted the update-ruff branch October 31, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant