upgrade codemirror and other dependencies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded codemirror and automerge, and then removed the
yarn.lockand re-resolved dependencies from scratch. I needed to clear the yarn.lock to clear up some issues w/ loading multiple instances of codemirror. I suspect that the issues that were seen previously weren't actually breakage in newer versions of codemirror, they were actually problems related to loading multiple instances of some codemirror package (which often leads to weird subtle behavior in codemirror)All cypress tests pass, including the "multiple newlines" test which seems to have been an issue w/ codemirror previously. Also tested the plugin in TEE and seems to work fine.