Add Read.getObjectType #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: sometimes you have an object ID but need to know what type of object the ID points at in order to determine what to do with it but there is no way of getting this information from automerge. Solution: add Read.getObjectType which returns the type of the object ID, or `Optional.empty` if the object is not in the document.
|
@eneroth does the API exposed here look useful for you? |
|
Optional returning a type. I think this looks good. The primary use case I have in mind is to a) conditionally create fields if they are missing, and b) to make assertions about the presence and type of fields, for example in tests. This looks suitable for both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: sometimes you have an object ID but need to know what type of object the ID points at in order to determine what to do with it but there is no way of getting this information from automerge.
Solution: add Read.getObjectType which returns the type of the object ID, or
Optional.emptyif the object is not in the document.Fixes #5