Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace croaring allocator to RedisModule allocator #66

Merged
merged 3 commits into from
Oct 29, 2020
Merged

replace croaring allocator to RedisModule allocator #66

merged 3 commits into from
Oct 29, 2020

Conversation

jiangtao244
Copy link
Contributor

@aviggiano
Copy link
Owner

aviggiano commented Oct 23, 2020

Hello @jiangtao244 thank you for contributing!
This is a much anticipated wanted feature, so it will be really useful for redis-roaring users (as it helps with #64 and closes #2).

I'll check this out soon, but from what I see it seems correct. The only thing I noticed is that you included roaring.[c,h] on the src files, although it is already part of external deps, so I think they are not necessary. Other than that seems good.

@jiangtao244
Copy link
Contributor Author

Please review the compile flags and check the benchmarks.

@aviggiano
Copy link
Owner

@jiangtao244 I have tested this locally and it works fine.
I just added a small change to the PR by removing roaring.h and roaring.c from this repo, since it would be harder to maintain instead of just copying the dependency file from the original repo: https://github.com/jiangtao244/redis-roaring/pull/1

After you accept these changes I will merge this

Remove dependency files from project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants