Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and at Fedora/RedHat installation guide #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

casch-at
Copy link

@casch-at casch-at commented Dec 3, 2022

Hey, I have updated the README a little and also added an installation guide for distributions using dnf/yum as package manager, like Fedora/RedHat. I'm not done yet. Are you interested in this PR? Is there anything I should change....?

Thanks,
Christian

@awesometic
Copy link
Owner

awesometic commented Dec 5, 2022

Hello,

Thank you for your contribution. It is really clean and organized well 👍
I looked into your changes and found a few things that I'd like to ask you to consider.

  1. Adding the r8169 module to the blacklist and updating initramfs are required for all methods.

Yeah, those are commonly required things for making r8125 module loaded for sure. Disabling r8169, and letting initramfs know there is the new r8125 module that it should load.

And, this is duplicated with the right below chapter. So that I think 4-iv to 4-viii should be edited along with the very next chapter.

  1. Difference between update-initramfs command and your method?

Adding r8125 driver to the modprobe, which is good to make sure the module loaded, but I can't be sure what is the difference between the update-initramfs command and your instructions.

Is it a more solid way or a special way for Fedora Linux? 🤔

  1. Centered contents in the table might be better ..?

How about this one? I changed the x mark to v, and centered them in the cell.

Nr Method Fedora/RedHat based Debian based
1 deb package v
2 Launchpad PPA v
3 autorun.sh v v
4 dkms-install.sh v (Recommended) v (Recommended)
| Nr | Method          | Fedora/RedHat based | Debian based    |
|----|-----------------|:-------------------:|:---------------:|
| 1  | deb package     |                     | v               |
| 2  | Launchpad PPA   |                     | v               |
| 3  | autorun.sh      | v                   | v               |
| 4  | dkms-install.sh | v (Recommended)     | v (Recommended) |

Please consider my suggestions.
Thank you 🙂

@casch-at casch-at force-pushed the doc-fedora branch 2 times, most recently from 66a1cc6 to d4f042d Compare January 1, 2023 17:47
@casch-at
Copy link
Author

casch-at commented Jan 1, 2023

@awesometic Done!

Fedora/RedHat uses the tool dracut instead of the initramfs-tools, but I have no glue why :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants