Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent AVCaptureSession from starting during session configuration #124

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

phantumcode
Copy link
Member

Issue #, if available:

Description of changes:

  • Update the logic for configuring and starting the AVCaptureSession so that starting the session is deferred after the session is configured to avoid AVCaptureSession crash as a result of in progress configuration of session.

Check points: (check or cross out if not relevant)

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@phantumcode phantumcode requested review from a team as code owners April 10, 2024 19:05
Copy link
Member

@thisisabhash thisisabhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, LGTM

Sources/FaceLiveness/AV/LivenessCaptureSession.swift Outdated Show resolved Hide resolved
@phantumcode phantumcode merged commit c318f91 into main Apr 11, 2024
6 checks passed
@phantumcode phantumcode deleted the fix/AVCaptureSession_crash branch April 11, 2024 16:54
@phantumcode phantumcode mentioned this pull request Apr 22, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants